#17419: Add a JSON template filter
-------------------------------------+-------------------------------------
     Reporter:  Lau Bech Lauritzen   |                    Owner:  Aymeric
                                     |  Augustin
         Type:  New feature          |                   Status:  new
    Component:  Template system      |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:  json template tag    |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by blighj):

 Replying to [comment:34 Mateusz Jankowski]:

 A review would be great, here is the current commit for the patch
 
https://github.com/blighj/django/commit/af32bab8f9575cb968cd92931cec6f442bf31723

 A general review would be good, plus specific things that should be looked
 at would be
 - naming the filter
 - location of functions, I thought it useful to have the main function
 available outside the template filter, so it could be reused and
 repurposed by other projects, so I included it in utils/html.py. This
 caused me issues with including DjangoJSONEncoder at the top of the file,
 so I included it in the function. Which is bad right?

--
Ticket URL: <https://code.djangoproject.com/ticket/17419#comment:35>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.a1c6fe415a96ed232e9ceb86eff35a87%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to