#23626: Change coding style for sql, params return lines
-------------------------------------+-------------------------------------
     Reporter:  mjtamlyn             |                    Owner:  aniav
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |                  Version:  master
    Component:  Database layer       |               Resolution:
  (models, ORM)                      |             Triage Stage:  Accepted
     Severity:  Normal               |      Needs documentation:  0
     Keywords:  afraid-to-commit     |  Patch needs improvement:  0
    Has patch:  0                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  1                    |
-------------------------------------+-------------------------------------

Comment (by aniav):

 There are quite a lot places where `%s` is used in ORM string manipulation
 and I am not quite sure that changing to format is a good idea. It's
 actually not helping much with readability especially in base SQL strings
 defined in `db/backend/schema.py`. Curly braces are also used in T-SQL for
 escaping Date, Time and Timestamp, and in PostgreSQL for supplying Array
 values - this wouldn't make the issue an easy picking one IMO.
 I am not really sure if changing that would have any positive outcome. I
 would just abandon the idea.

--
Ticket URL: <https://code.djangoproject.com/ticket/23626#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.11e1c4903c19607310bf60ca48afcbba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to