#23626: Change coding style for sql, params return lines
-------------------------------------+-------------------------------------
Reporter: mjtamlyn | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Database layer | Resolution:
(models, ORM) | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Comment (by mjtamlyn):
This ticket was opened two days ago and there are no commits along those
lines I can see. For example I mean places like:
https://github.com/django/django/blob/bc46e4d4fa61eead13fe58048ae646f07d632e4f/django/db/models/lookups.py#L149-L154
https://github.com/django/django/blob/92a17eaae081a213171b044858d6fc29df2df733/django/contrib/postgres/fields/array.py#L167-L172
There aren't that many, and several are clearer to read than the examples
in that PR. The docs however suggest the current style used. It may be
worth looking more generally at string manipulation in the ORM and using
`.format()` instead of `%s` notation.
--
Ticket URL: <https://code.djangoproject.com/ticket/23626#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.5a81c63b7a99dd20cbc8bbd1c09b389d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
