#23581: Migration shouldn't generate "DROP DEFAULT" SQL if no database changes 
are
required
--------------------------------------+------------------------------------
     Reporter:  john_scott            |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Migrations            |                  Version:  1.7
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by timgraham):

 More tests in Django's test suite are definitely needed. I can comment out
 every usage of `sql_alter_column_no_default` in `db/backends/schema.py`
 and there are no test failures in migrations or schema. There was also a
 suggestion by Claude to check if the default was `NOT_PROVIDED`:
 https://code.djangoproject.com/ticket/23719#comment:2. Anyway, if you can
 send a pull request with a solution and some tests I'll be happy to take a
 closer look.

--
Ticket URL: <https://code.djangoproject.com/ticket/23581#comment:22>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a49d10d322a8d2e96ef90c6b80408f56%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to