#23581: Migration shouldn't generate "DROP DEFAULT" SQL if no database changes
are
required
--------------------------------------+------------------------------------
Reporter: john_scott | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by john_scott):
The standalone `DROP DEFAULT` comes from
[https://github.com/django/django/blob/f633ba778d302c12f4295714a78fa20dff98b39f/django/db/backends/schema.py#L715
this line] in schema.py. Essentially anything that triggers _alter_field
will end up passing this test and it will insert the `DROP DEFAULT` into
the output. Perhaps shaib's comment in comment:18 is the fix for this line
and that is enough to resolve the only remaining issue in this ticket?
Unless generating add/drop as in comment:17 when the field was already not
NULL is also undesirable behavior. Both of these seem harmless for the
most part, just unexpected behavior that was uncovered while debugging
something else.
--
Ticket URL: <https://code.djangoproject.com/ticket/23581#comment:21>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.8b251e4457be99c7ea37fc3fa7430056%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
