Yes, I understand. Don't merge incorrect solutions. But notice that it is a regression, in the affected languages. Things just stop working after upgrading Django. If I didn't have the unit tests which failed, I might have upgraded Django to production and my users would have received messages in an incorrect language. There is not even an exception raised when the messages are not translated. It just happens that the language I'm using is not the most popular language Django users are using, but it is a regression. It's also not documented in the release notes, as I would expect it to be documented there. אורי [email protected]
On Wed, Mar 4, 2020 at 7:22 PM Carlton Gibson <[email protected]> wrote: > We are taking it seriously Uri. It’s difficult to resolve instantly when > there’s a super long mailing list thread, and several PRs in play, and a > major discussion on the ticket. It’s only recently that the correct > approach has become clear. It’s taken a community effort, from i18n experts > to get there. > > Before that there was pressure to quickly merge incorrect solutions. > > Then we have security issues to resolve, such as two SQL injection issues > in the last couple of months. These take priority. > > Sorry if things go slower than you’d like. There’s more to it than perhaps > there seems. (Not least the danger of introducing regressions, especially > if we do decide to backport, as you’d like.) > > > On Wed, 4 Mar 2020 at 18:14, אורי <[email protected]> wrote: > >> Hi Carlton, >> >> I think this issue is important for the Django developers mailing list. I >> already commented on the PR about 3 weeks ago. Yes I know that most Django >> users use either English, or a language which its plural forms were not >> changed recently. But users who use a language whose plural forms changed, >> for example Hebrew in Django 2.2, have problems upgrading Django to 2.2 >> without serious consequences. I don't know how many users like this there >> are, except the users who commented on this ticket, which are only about 4 >> or 5 users as far as I remember. But think about it this way - if the >> language affected was English, would you act differently? The ticket is >> from 10 months ago (May 2019), since then there is a problem with Django >> 2.2, and I noticed you released recently a new Django version. I think you >> (the Django developers) should take this issue seriously and not like "That >> one user has a bug". >> >> אורי >> [email protected] >> >> >> On Wed, Mar 4, 2020 at 3:43 PM Carlton Gibson <[email protected]> >> wrote: >> >>> HI Uri. >>> >>> Yes, we know. :) Please don't bump. It's just adds noise. (If you MUST >>> bump, a comment on the PR is more than enough, so not everyone of the >>> thousands on this list needs a notification.) Thanks. >>> >>> Ref backport: it's a possibility but you should phrase it more like, >>> "this is serious bug for any user of i18n supporting non-latin >>> languages"[*] — or similar. (That one user has a bug wouldn't qualify it.) >>> — It is under consideration. >>> >>> >>> https://www.goodreads.com/book/show/4865.How_to_Win_Friends_and_Influence_People >>> (Ch1.) >>> >>> On Wednesday, 4 March 2020 14:20:10 UTC+1, Uri wrote: >>>> >>>> Django developers, >>>> >>>> PR #12332 is waiting to be reviewed and approved. >>>> >>>> https://github.com/django/django/pull/12332 >>>> >>>> I would also like to suggest to include this PR, if accepted, into the >>>> next version of 2.2. Otherwise I will not be able to use 2.2 or I will have >>>> to fork Django to use 2.2, and then I will have to apply every patch >>>> manually to my fork, which is a harass and I don't think should be >>>> necessary. >>>> >>>> אורי >>>> [email protected] >>>> >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/CABD5YeGCfRT07uRpM3phmQFpNJz%2BFouKt1N4Ty%3D9tC0-Uz-Bjw%40mail.gmail.com >> <https://groups.google.com/d/msgid/django-developers/CABD5YeGCfRT07uRpM3phmQFpNJz%2BFouKt1N4Ty%3D9tC0-Uz-Bjw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAJwKpyTngRNidxiJXsc7a3McQqtVp-TSjrdWheCq5s6j8r%3DLwg%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CAJwKpyTngRNidxiJXsc7a3McQqtVp-TSjrdWheCq5s6j8r%3DLwg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CABD5YeHhLeeGL407nUwjYXvieCBQ_is5G%2BoMztdR6m9VVmLxmQ%40mail.gmail.com.
