On Tue, Sep 25, 2012 at 1:31 AM, Shai Berger <[email protected]> wrote: > On Sunday 23 September 2012, Anssi Kääriäinen wrote: >> Doing final polish for Ian's patch and providing benchmark results for it >> will get this patch closer to commit. >> > I had hoped the Django test suite alone will provide a convincing benchmark, > but apparently that is not the case -- on my laptop, with Oracle in a virtual > machine, the basic suite takes 63 minutes with or without the patch. This > makes sense, because the effect is likely to be evident mostly in queries > returning many rows, and those are not very common in the test suite. > > I do not have a working Django-trunk project to test on, and this evening and > tomorrow is a very sacred holiday here (Yom Kippur), so it might take me until > the end of the week to produce benchmark results. If anyone wants to chime in, > the pull request is https://github.com/django/django/pull/393. There is, so > far, anecdotal evidence of very significant improvements, from Ian Kelly > (original author of this patch) and myself (on a somewhat different > implementation and older Django versions, but same general idea). In my case, > page load times were cut by dozens of percents.
Thanks for putting together a pull request. Please note the patch will also need to update the documentation to state the new cx_Oracle version requirement (was 4.3.1, now 5.0.1). Cheers, Ian -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
