On 22 syys, 23:34, Shai Berger <[email protected]> wrote: > On Wednesday 05 September 2012, Ian Kelly wrote: > > > > > Thanks for tracking that down. _rowfactory was a module-level > > function rather than a method, and I should have left it that way. > > So -- Ian, Anssi, are you going to include the fix in Django 1.5? I can help > by > either reviewing it for you or providing the patch for you to review. > > If you let me write the patch, I will also include the extra setting in the > "options" dictionary (choosing if expressions should be treated as decimals or > floats). I think this is then an added feature, and needs to get in before the > feature freeze. Otherwise, just fixing the performance can be treated as a bug > in be included later. Is this guess correct?
Yes, the optimization part can get in after feature freeze. Applying it even at relatively late stage to 1.5 sounds OK to me. There isn't much time to do feature additions. It is possible to get the feature into 1.5, but you should not expect it to happen. As for the feature itself, I am not yet sure if it is a good idea or not. The basic problem is granularity: wouldn't you want to do this per query, or even per expression basis? Of the wording "if you let me write the patch" - of course you can write a patch. Even if somebody else claims to be working on this, you can still write a competing patch. It is not advisable as work is likely going to be wasted, but you can do it. Doing final polish for Ian's patch and providing benchmark results for it will get this patch closer to commit. If you decide to work on this, please split the patch into two: one for the ._rowfactory change, one for the feature addition. My belief is that the ._rowfactory change is going to be something we can very easily justify committing into 1.5, but the proposed feature addition sounds like something which isn't as obvious. I am ready to review patches related to this issue, but otherwise I don't have any plans to work on this. I hope Ian has some time available for this feature, as he knows a lot more about Oracle than I do. - Anssi -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
