I agree. But the problem is this: CreateView has a default template: %app_name%/%model_name%_form.html , however, it should raise an error if no queryset or model is passed. The SingleObjectMixin-get_model.diff patch does this. It just needs tests.
I would create a seperate ticket for handling an empty list of templates. Tino On Thu, Sep 15, 2011 at 21:51, Aymeric Augustin < [email protected]> wrote: > Hello, > > Yes, I think ticket #16502 should focus on the problem of CreateView: why > doesn't it have a default template and does it need one? > > The other issues you discovered while investigating that problem should go > into separate tickets. > > Best regards, > > -- > Aymeric Augustin. > > On 15 sept. 2011, at 09:12, Silver_Ghost wrote: > > There is a comment<https://code.djangoproject.com/ticket/16502#comment:10>to > ticket ticket > #16502 <https://code.djangoproject.com/ticket/16502> from *ptone*. He > recommends to create two new tickets, one for get_model patch and one for > select_template patch. In my opinion separating select_template patch is > a good idea while separating get_model patch isn't. This is becauseadding > get_model method fully fixes ticket #16502. > > What should I do? If creating two new tickets as *ptone* suggests is a > right way then how to show relation between this three tickets? > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/django-developers/-/zQT8_CaxmyUJ. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
