Hi Ben, This is the back trace I see in the debugger on connection loss with the controller:
ofproto_flush_flows fail_open_run connmgr_run ofproto_run Later during ofproto_run, ofproto_flush__ is called and actually deletes the rules from ofproto. So it seems to me that OVS does delete flows when it loses connection to the controller. Am I missing something? Thanks, Gur -----Original Message----- From: Ben Pfaff [mailto:b...@nicira.com] Sent: Monday, September 22, 2014 20:08 To: Gur Stavi Cc: discuss@openvswitch.org Subject: Re: [ovs-discuss] Meter IDs and meter cleanup on disconnect On Sun, Sep 21, 2014 at 05:33:36AM +0000, Gur Stavi wrote: > I have 2 questions about meters: > > If OVS loses connection to controller it delete active flows No, it doesn't. > but does not delete active meters. Shouldn't meters be deleted as > well. How are you adding meters? The FAQ says: Q: Does Open vSwitch support OpenFlow meters? A: Since version 2.0, Open vSwitch has OpenFlow protocol support for OpenFlow meters. There is no implementation of meters in the Open vSwitch software switch (neither the kernel-based nor userspace switches). > Meters are stored in an array in ofproto where meter_id is used as an index > into the array. > The datapath need to pre-declare the array size using max_meters during a > call to meter_get_features. > This puts a hard limit on the range of Meter IDs 0-max_meters. > It may be very convenient to the controller to have freedom in the selection > of meter_id 32 bits in order to easily associate flows to meters. This is not an Open vSwitch restriction. It comes straight from the OpenFlow specification: "Meters are defined starting with meter_id=1 up to the maximum number of meters that the switch can support." > For example: if the bridge states that max_meters=4 the controller may want > to select meter-ids as a function of vlan: 1000, 1200, 1560, 3420. > Is it possible to change meters in ofproto from an array into hash? Only if you change OpenFlow first. [E-Banner]<http://www.mrv.com/products/optidriver> The contents of this message, together with any attachments, are intended only for the use of the person(s) to whom they are addressed and may contain confidential and/or privileged information. If you are not the intended recipient, immediately advise the sender, delete this message and any attachments and note that any distribution, or copying of this message, or any attachment, is prohibited. _______________________________________________ discuss mailing list discuss@openvswitch.org http://openvswitch.org/mailman/listinfo/discuss
