OpenFlow uses the OFPT_HELLO message in the first message exchange of a given OpenFlow session to negotiate a particular version, and after that every message on the channel should use that version. Any controller that depends on other behavior is buggy.
Nevertheless, I don't have a particular reason to adopt the new behavior, so I'm willing to change the behavior back, if you provide a reasonable patch that does so. On Tue, Jul 03, 2012 at 09:50:28AM +0530, sonny sonny wrote: > Hi Ben, > > My intention is just if any different version is coming on switch then > it should have handle capability (as per openflow spec 1.0 also) . > I think the version in switch's "error" packet should be the one which > switch is using so that other (controller) would come to know the > right version. > It was working before in OVS 1.2.2 > Just need to know is there any specific reason to change this design? > > Regards > Sonny > > On Tue, Jul 3, 2012 at 12:17 AM, Ben Pfaff <b...@nicira.com> wrote: > > It seemed reasonable to send the error with the same version as the > > request. I can't see how it really matters since no controller should > > send a request with the wrong version anyway. So, why does it matter > > to you? > > > > On Fri, Jun 29, 2012 at 11:45:17PM +0530, sonny sonny wrote: > >> hi , > >> Please help us in understanding the error packet designing. > >> > >> On Fri, Jun 29, 2012 at 11:04 PM, sonny sonny <sonny...@gmail.com> wrote: > >> > hi Ben, > >> > We both were working on this.Sorry for confusion..Please help us in > >> > understanding the design change.. > >> > > >> > > >> > On Fri, Jun 29, 2012 at 10:57 PM, Ben Pfaff <b...@nicira.com> wrote: > >> >> Who are you? Are you the same person as "sonny sonny"? Is this the > >> >> same question or a different one? > >> >> > >> >> On Fri, Jun 29, 2012 at 10:39:22PM +0530, Amit Tewari wrote: > >> >>> hi, > >> >>> i wanted to display BAD_VERSION error from switch to controller..am > >> >>> working > >> >>> on error handling on my controller from switch. But why is switch > >> >>> behaving > >> >>> like this, > >> >>> i also used openvswitch-1.2.2 there error packet header version from > >> >>> switch was 1 not 3 . what is this design change in 1.6 version > >> >>> > >> >>> On Fri, Jun 29, 2012 at 9:45 PM, Ben Pfaff <b...@nicira.com> wrote: > >> >>> > >> >>> > On Fri, Jun 29, 2012 at 05:06:32PM +0530, sonny sonny wrote: > >> >>> > > Following is my setup on openvswitch 1.6.1 > >> >>> > > controller - nox 0.9.0(zaku) > >> >>> > > Switch generates error packet for vendor message from controller, > >> >>> > > with > >> >>> > > header version as 1 in error packet , which is correct behaviour of > >> >>> > > switch. > >> >>> > > But when i change header version to 3 in vendor message on > >> >>> > > controller > >> >>> > > i recieve error packet with version 3 from switch and not with > >> >>> > > version 1 which is strange behaviour on switch. > >> >>> > > I checked the code and i found that in error handling now error > >> >>> > > packet > >> >>> > > version is set to the request packet version. > >> >>> > > >> >>> > Why did you send a vendor message with an OpenFlow version other than > >> >>> > the negotiated version? > >> >>> > _______________________________________________ > >> >>> > discuss mailing list > >> >>> > discuss@openvswitch.org > >> >>> > http://openvswitch.org/mailman/listinfo/discuss > >> >>> > > >> >>> > >> >>> > >> >>> > >> >>> -- > >> >>> Amit Tewari > >> >>> > >> >>> Software Engineer > >> >>> > >> >>> > >> >>> > >> >>> Ph::9711009046 _______________________________________________ discuss mailing list discuss@openvswitch.org http://openvswitch.org/mailman/listinfo/discuss
