tlopex commented on code in PR #19829:
URL: https://github.com/apache/tvm/pull/19829#discussion_r3437649684
##########
src/arith/ir_mutator_with_analyzer.h:
##########
@@ -47,6 +47,7 @@ namespace arith {
*/
class IRMutatorWithAnalyzer : public tirx::StmtExprMutator {
public:
+ explicit IRMutatorWithAnalyzer(const Analyzer& analyzer) :
analyzer_(analyzer.get()) {}
Review Comment:
since `RewriteSimplifier::Impl` are members of AnalyzerObj constructed from
this, I think owning analyzer_ would make AnalyzerObj hold a handle back to
itself, does that safe?
##########
src/arith/ir_mutator_with_analyzer.h:
##########
@@ -47,6 +47,7 @@ namespace arith {
*/
class IRMutatorWithAnalyzer : public tirx::StmtExprMutator {
public:
+ explicit IRMutatorWithAnalyzer(const Analyzer& analyzer) :
analyzer_(analyzer.get()) {}
Review Comment:
since `RewriteSimplifier::Impl` are members of AnalyzerObj constructed from
`this`, I think owning analyzer_ would make AnalyzerObj hold a handle back to
itself, does that safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
