tqchen commented on code in PR #19829:
URL: https://github.com/apache/tvm/pull/19829#discussion_r3436660357
##########
src/arith/ir_mutator_with_analyzer.h:
##########
@@ -47,6 +47,7 @@ namespace arith {
*/
class IRMutatorWithAnalyzer : public tirx::StmtExprMutator {
public:
+ explicit IRMutatorWithAnalyzer(const Analyzer& analyzer) :
analyzer_(analyzer.get()) {}
Review Comment:
In this particular case, to ensure we have good lifeness, i think it is
better to simply make analyzer_ member as Analayzer, so you can have a
constrctor that takes in Analyzer here, this avoid case where Analzyer itself
runs out of lifescope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
