tomayac commented on code in PR #19780:
URL: https://github.com/apache/tvm/pull/19780#discussion_r3418327434
##########
web/src/artifact_cache.ts:
##########
@@ -17,7 +17,9 @@
* under the License.
*/
-import { OPFSStore } from "./opfs_store";
+import { OPFSStore, type OPFSAccessMode } from "./opfs_store";
+
+export type { OPFSAccessMode } from "./opfs_store";
Review Comment:
Thanks for the review! These are pre-existing in `main` — `OPFSAccessMode`
and the `accessMode` constructor parameter were introduced in
`web/src/opfs_store.ts` before this PR was opened and are already present on
`main`. This PR only touches the COS-specific lines (`requestFileHandle`
rename).
##########
web/src/artifact_cache.ts:
##########
@@ -556,8 +604,8 @@ export class ArtifactIndexedDBCache implements
ArtifactCacheTemplate {
export class ArtifactOPFSCache implements ArtifactCacheTemplate {
private readonly store: OPFSStore;
- constructor(scope: string) {
- this.store = new OPFSStore(scope);
+ constructor(scope: string, accessMode: OPFSAccessMode = "async") {
+ this.store = new OPFSStore(scope, accessMode);
}
Review Comment:
Thanks for the review! These are pre-existing in `main` — `OPFSAccessMode`
and the `accessMode` constructor parameter were introduced in
`web/src/opfs_store.ts` before this PR was opened and are already present on
`main`. This PR only touches the COS-specific lines (`requestFileHandle`
rename).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
