gemini-code-assist[bot] commented on code in PR #19780:
URL: https://github.com/apache/tvm/pull/19780#discussion_r3412825945
##########
web/src/artifact_cache.ts:
##########
@@ -17,7 +17,9 @@
* under the License.
*/
-import { OPFSStore } from "./opfs_store";
+import { OPFSStore, type OPFSAccessMode } from "./opfs_store";
+
+export type { OPFSAccessMode } from "./opfs_store";
Review Comment:
The type `OPFSAccessMode` is imported and exported from `./opfs_store`, but
it is not defined or exported in `web/src/opfs_store.ts`. This will cause a
TypeScript compilation error.
##########
web/src/artifact_cache.ts:
##########
@@ -556,8 +604,8 @@ export class ArtifactIndexedDBCache implements
ArtifactCacheTemplate {
export class ArtifactOPFSCache implements ArtifactCacheTemplate {
private readonly store: OPFSStore;
- constructor(scope: string) {
- this.store = new OPFSStore(scope);
+ constructor(scope: string, accessMode: OPFSAccessMode = "async") {
+ this.store = new OPFSStore(scope, accessMode);
}
Review Comment:
The `OPFSStore` constructor in `web/src/opfs_store.ts` only accepts a single
parameter `scope: string`. Passing `accessMode` as a second argument will
result in a TypeScript compilation error. If `accessMode` support is intended,
`web/src/opfs_store.ts` needs to be updated to support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
