MakotoUwu commented on PR #19771: URL: https://github.com/apache/tvm/pull/19771#issuecomment-4709429475
Addressed the Gemini follow-up comments in the latest commit: - `ArrayDecodeStorage` now honors `cpu_arr->byte_offset` in the packed bf16 expansion path, so chunk views write to the correct offset. - `storageBytes` now handles `bool` explicitly. - The GPU chunk copy path now creates both views before detaching them from the scope, avoiding a leak if the second view creation throws. - `kTVMFFIShape` callback decoding now guards against a null shape object pointer. Local checks still pass: `npm run lint`, `npx tsc --noEmit --pretty false`, and `git diff --check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
