MakotoUwu commented on PR #19771: URL: https://github.com/apache/tvm/pull/19771#issuecomment-4708265203
Thanks for the review. I updated the PR to narrow the scope and make the motivation more explicit: - Removed the FFI include reordering change from this PR. I agree the previous static-init wording was too strong without a concrete wasm startup trace in this split PR, so this now leaves the existing include order unchanged. - Kept the large tensor-cache record chunking and clarified the motivation in the PR description and code comment. The concrete case is a single tensor-cache record larger than the conservative WebGPU staging/view size used by the web runtime. The 128 MiB cap follows the existing `maxStorageBufferBindingSize` fallback in `web/src/webgpu.ts`; it is only a per-decode/per-copy view cap for loading large records, while smaller records still use the existing full-record path. Local checks still pass after the update: `npm run lint`, `npx tsc --noEmit --pretty false`, and `git diff --check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
