akaashrp commented on code in PR #18960:
URL: https://github.com/apache/tvm/pull/18960#discussion_r3018698437
##########
src/target/source/codegen_webgpu.cc:
##########
@@ -130,6 +130,13 @@ runtime::FunctionInfo CodeGenWebGPU::AddFunction(const
PrimFunc& f, bool skip_re
name_supply_->ReserveName("let");
name_supply_->ReserveName("const");
name_supply_->ReserveName("std");
+ name_supply_->ReserveName("storage");
+ name_supply_->ReserveName("uniform");
+ name_supply_->ReserveName("workgroup");
+ name_supply_->ReserveName("private");
+ name_supply_->ReserveName("function");
+ name_supply_->ReserveName("read");
+ name_supply_->ReserveName("read_write");
Review Comment:
This is not an extensible solution since the list could keep growing as the
WebGPU API supports additional datatypes or keywords. Additional collisions can
be handled as they arise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
