gemini-code-assist[bot] commented on code in PR #18960:
URL: https://github.com/apache/tvm/pull/18960#discussion_r3018675448
##########
src/target/source/codegen_webgpu.cc:
##########
@@ -130,6 +130,13 @@ runtime::FunctionInfo CodeGenWebGPU::AddFunction(const
PrimFunc& f, bool skip_re
name_supply_->ReserveName("let");
name_supply_->ReserveName("const");
name_supply_->ReserveName("std");
+ name_supply_->ReserveName("storage");
+ name_supply_->ReserveName("uniform");
+ name_supply_->ReserveName("workgroup");
+ name_supply_->ReserveName("private");
+ name_supply_->ReserveName("function");
+ name_supply_->ReserveName("read");
+ name_supply_->ReserveName("read_write");
Review Comment:
The list of reserved keywords should be more comprehensive to avoid similar
collisions with other WGSL predeclared identifiers and keywords. Specifically,
`write` and `handle` should be included alongside the other access modes and
address spaces. Additionally, fundamental keywords and reserved words like
`fn`, `struct`, `ptr`, `atomic`, `override`, `true`, `false`, and basic type
names (`f32`, `f16`, `i32`, `u32`, `bool`) should be reserved to ensure
robustness.
```c
name_supply_->ReserveName("storage");
name_supply_->ReserveName("uniform");
name_supply_->ReserveName("workgroup");
name_supply_->ReserveName("private");
name_supply_->ReserveName("handle");
name_supply_->ReserveName("function");
name_supply_->ReserveName("read");
name_supply_->ReserveName("write");
name_supply_->ReserveName("read_write");
name_supply_->ReserveName("fn");
name_supply_->ReserveName("struct");
name_supply_->ReserveName("ptr");
name_supply_->ReserveName("atomic");
name_supply_->ReserveName("override");
name_supply_->ReserveName("true");
name_supply_->ReserveName("false");
name_supply_->ReserveName("f32");
name_supply_->ReserveName("f16");
name_supply_->ReserveName("i32");
name_supply_->ReserveName("u32");
name_supply_->ReserveName("bool");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
