Yo Hal! On Sat, 14 May 2022 17:42:59 -0700 Hal Murray via devel <devel@ntpsec.org> wrote:
> I'm cc-ing devel so this doesn't get lost on gitlab. Let's move the
> discussion real email..
>
>
> > include/ntp_fp.h:58 defines l_fp as a uint64_4, I can find no
> > current contrary definitions.
>
> We need to make a cleanup pass in this area.
>
> On the wire, it's unsigned. As soon as the code gets 2 of them, it
> does a subtract so we need a signed version. We need to check for
> underflow on the initial subtract.
>
> There is also u_fp, a 32 bit version. The comment says there is a
> s_fp, but I can't find it.
>
> -------
>
> I think we should comment out this test until we get the release out.
> Please include references to both issues and this message/thread.
I'm OK with commenting it out, just the two lines, until we figure out
what clang is doing. But I'd rather figure it out...
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
g...@rellim.com Tel:+1 541 382 8588
Veritas liberabit vos. -- Quid est veritas?
"If you can't measure it, you can't improve it." - Lord Kelvin
pgp0fL5IJ_Vty.pgp
Description: OpenPGP digital signature
_______________________________________________ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel
