Hi Hal, If you're sufficiently happy with my code change, then you can click "approve" and "merge" on https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1264
I would rather not add knobs unless someone asks for this to be a knob. Thanks, -Matt ________________________________ From: Hal Murray <halmur...@sonic.net> Sent: Wednesday, April 20, 2022 2:12 PM To: Matt Selsky <matthew.sel...@twosigma.com> Cc: devel@ntpsec.org <devel@ntpsec.org>; Hal Murray <halmur...@sonic.net> Subject: Re: Getting ready for a release, wildcards [The mail system is in sloth mode again.] matthew.sel...@twosigma.com said: > I don't think we should have a knob for disabling wildcards. This is not the > sort of knob that operators expect (what other software provides such a > knob?) and we're just adding another code path to test. I'll be interested in other opinions. Just because nobody else does it doesn't mean it's a bad idea. Somebody has to go first. If it's extra code on our end, think of all the code in OpenSSL that we don't exercise if we don't allow wildcards. I have running code. The default is to allow wildcards so nobody will get surprised. I can push later today. If you want to go the merge request route, somebody will have to give me a lesson. -- These are my opinions. I hate spam. _______________________________________________ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel
