On Fri, Jul 10, 2026 at 19:06:31 +0200, Roman Bogorodskiy wrote:
>   Peter Krempa wrote:

[...]


> > This error path is convoluted. There's 3 distinct branches triggering on
> > ret < 0.
> > 
> > I suggest you consolidate them. This will cause that
> > the call to bhyveDomainNamePathsCleanup will be duplicated in both
> > branches but it will be IMO much more clear  what is happening on succes
> > sand what on error.
> 
> Thanks for the suggestions, applied and merged.
> 
> In the meantime, all of these three items are applicable to
> qemuDomainRenameCallback(). Please let me know if you want me to address
> them there too.

If you have the motivation to fix that one too go ahead. It definitely
is not a requirement for your implementation.

Reply via email to