On a Thursday in 2025, Nikolai Barybin via Devel wrote:
Signed-off-by: Nikolai Barybin <[email protected]> --- docs/manpages/virsh.rst | 39 ++++++++++ tools/virsh-domain.c | 160 ++++++++++++++++++++++++++++++++++++++++ tools/vsh.c | 14 ++++ tools/vsh.h | 2 + 4 files changed, 215 insertions(+)diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index bcb5495ed9..16c4f5d28d 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -1626,6 +1626,45 @@ on the *bandwidth* argument see the corresponding section for the ``blockjob`` command. +blockrebase-params
The -params suffix is not of any help for the virsh users. We only use the Params suffix when we need to add a new API with parameter support which has an older alternative without them (we need to keep the older one because we maintain ABI compatibility). For virsh, the latest version can be used to remotely connect to older versions of libvirt, so if whatever the user asked for can be satisfied with the usage of the older API, virsh tries that instead of the new one. If the functionality is sufficiently similar to the blockpull command, I suggest you put it there and only call the new API when the user requested the extra stuff. Jano
signature.asc
Description: PGP signature
