On 6/19/26 7:29 PM, Gordon Messmer wrote:
Ben, I agree with most of your points, but I want to rephrase my
question:
Is there an explicit allowance for Node.JS packages to include
pre-built binaries in their source archives, or is the presence of
pre-built binaries an oversight?
I think it's an oversight, because most of the Node.JS packages that I
have looked do strip binary content from the packaged application's
own source.
And if it IS an oversight, then we're probably going to have to go
back and re-review everything that's bundling node_modules.
It does NOT seem to be banned to include pre-built stuff in the source
archive, there is even an implication that it is OK in the source
archive in the guidelines:
I am guessing this is the most relevant section:
https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#prebuilt-binaries-or-libraries
"""
When you encounter prebuilt binaries in a package you *MUST*:
*
Remove all pre-built program binaries and program libraries in %prep
prior to the building of the package. Examples include, but are not
limited to, |*.class|, |*.dll|, |*.DS_Store|, |*.exe|, |*.jar|,
|*.o|, |*.pyc|, |*.pyo|, |*.egg|, |*.so|, |*.swf| files.
"""
Things can be removed in %prep only if they are present in the RPM build.
If there are pre-built binary files that are *shipped* and in binary
RPMs and not checked, that does sound like an issue.
Of course from that FPG there is also the sentence "Some pre-packaged
program binaries or program libraries may be under terms which do not
permit redistribution"
Regards,
Jarek
--
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it:
https://forge.fedoraproject.org/infra/tickets/issues/new
