I've started a review of a nodejs package, and its bundled node_modules include wasm and native binaries. I wanted to provide the packager with examples of packages that fix up their node_modules properly, but I'm actually a little confused by what I found.

I picked nodejs-undici for reference, since it has a sources script: https://src.fedoraproject.org/rpms/nodejs-undici/blob/rawhide/f/undici-sources.sh

That script removes wasm and rebundles the code, but only for the program itself. It's not stripping the node_modules directories of pre-built content. The prod directory is relatively small and I didn't see any pre-built binaries, but the dev directory contains "esbuild" ELF binaries.

Shouldn't node_modules be stripped of this kind of content before uploading source?

What package would you recommend as an reference example?

--
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to