Florian Weimer venit, vidit, dixit 2026-06-19 16:31:24: > * Miro Hrončok: > > > On 19. 06. 26 15:38, Florian Weimer wrote: > >> The Packaging Guidelines currently say this, under Spec Legibility: > >> | To help facilitate legibility, only macros and conditionals for > >> Fedora > >> | and EPEL are allowed to be used in Fedora Packages. Use of macros and > >> | conditionals for other distributions, including Fedora derivatives, is > >> | not permitted in spec files of packages in the main Fedora > >> | repositories unless those macros and conditionals are also present in > >> | Fedora. > >> <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_encoding> > >> I would like to get this changed to explicitly permit %fedora, > >> %rhel, > >> %centos, %epel. And augment this list with %hummingbird, now that > >> Hummingbird images are part of the Fedora family. > >> What's the best way to build consensus for this kind of a change to > >> the > >> Packaging Guidelines, and implement it? > > Open a ticket (or a ticket and a PR) at > > https://forge.fedoraproject.org/packaging/guidelines > > Here's the ticket: > > Clarify distribution conditionals in spec files > <https://forge.fedoraproject.org/packaging/guidelines/issues/1546> > > > Not sure about %hummingbird, as there is probably not much usage. Do > > we know more information about macros in Hummingbird's build > > environment? > > Hummingbird does not define %rhel, so they typically change %rhel to > %rhel || %hummingbird in the spec files they forked. You can see > examples in their monorepo: > > > <https://gitlab.com/search?search=%25%7B%3Fhummingbird%7D&project_id=73447720&group_id=112699049&search_code=true&repository_ref=main> > > I don't expect that to be rolled out across all Fedora spec files. (In > my opinion, Hummingbird should define %rhel …) They don't want to fork > our package, but want a change that is not suitable for Fedora nor RHEL. > I disagree quite strongly with the change, so I'd prefer if the macro > for it explicitly referenced Hummingbird.
I'd say project hummingbird needs to figure out their identity crisis before anything else. That being said: > >> | not permitted in spec files of packages in the main Fedora > >> | repositories unless those macros and conditionals are also present in > >> | Fedora. What does "present in Fedora" in the "unless" part mean? It cannot mean "in the Fedora spec file", because then the guideline would say: "x is not allowed in a Fedora spec file unless it is in a Fedora spec file". Which is non-sense, of course. It can only mean that you are not supposed to use macros and conditionals which are undefined in Fedora. Which is something we do all the time, of course, hopefully catching the undefined case. So, that rule only seems to exclude the case that you rely on the presence of a macro which is present on another distro only? A first step might be to clear up what we want here. As for hummingbird: They say they want to "downstream" fixes towards rawhide. Consequently, there is clearly no need to have hummingbird conditionals in rawhide, is there? They can conditionalize in their repo what they want, of course. Michael -- _______________________________________________ devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
