Miro Hrončok venit, vidit, dixit 2025-07-11 00:19:38: > On 18. 06. 25 22:22, Michael J Gruber wrote: > > This example and most that I know use a BR on python3-devel and > > %pyproject_buildrequires, whereas the guidelines tell you to use *one* > > of them. The result with both is the same as with just the macro, but > > the path there is different: in the latter case the macro installs > > python3-devel. I don't mind either way, but maybe we should decide on a > > "best practice" and have the guidelines and examples match. > The guidelines say you MUST use at least one of them.
No, please don't misquote the guidelines when I refer to them explicitely. "Such a package MUST use one of the following ..." Specifically, it does not say "at least one" but uses "one", the number, which - in English - is different from the indefinite article. (It's the same in my language, which leads to many misundestandings.) In that form I understand it as "exactly one", since "one" is the number, as I'd reckon every mathematician would ;) If "at least one" is meant then the guideline should say so. > The best practice however, is to follow the examples in the guidelines. And that is why I ask - the two option lead to different behaviour, even though most likely the same result. > The reason for the rule is that: > > 1) Not all RPM packages that need BR on python3-devel are "Python packages" > to > use %pyproject_* macros. Sure. Use just python3-devel then. > 2) Packages that use the pyproject declarative BuildSystem to reduce > boilerplate use %pyproject_buildrequires implicitly and gain a BR on > python3-devel. Sure. Use just %pyproject_buildrequires then. So, as you underline yourself, there is never a reason to use more than one of these alternatives. In that sense it is beyond me why the "best practice" is "best". I'm not claiming it's bad. But doc and example on the same page should align. Also, I want to do the right thing and want to know what it is :) Michael -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
