On 10. 06. 25 13:59, Cristian Le via devel wrote:
I believe some clarification for this proposal is in order
What kind of clarification do you think is needed?
On 2025/06/07 14:49, Aoife Moloney wrote:
Old:
%build
%py3_build
New:
%build
%pyproject_wheel
The %py3_build expands to `python3 setup.py build` [1] which is the interface
that is being removed. %pyproject_wheel expands to `pip wheel` [2], which will
read setup.py and build (presumably without calling the removed interface).
More or less, yes. It might not read setup.py if pyproject.toml says otherwise.
But for 99.9 % packages that worked with %py3_build, this is the case, yes.
Do you believe such technical detail needs to be in the proposal?
That's why changing the interface to %pyproject_wheel would be enough, as long
as pip would be working properly with the new setuptools (should not give a
deprecation warning if run currently).
Well, that's not enough, because then you *also* need to use
%pyproject_buildrequires and %pyproject_install. (As shown in the example in
the proposal.)
But using the 3 macros (and updating the %files section from egg-info to
dist-info) instead of the removed 2 is indeed enough, yes.
--
Miro Hrončok
--
Phone: +420777974800
Fedora Matrix: mhroncok
--
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
