On Wed, Apr 30, 2025, at 4:47 PM, Ankur Sinha wrote:
> On Tue, Apr 29, 2025 13:44:05 +0200, Vít Ondruch wrote:
>> Seems this is the failing test suite, right?
>> https://download.copr.fedorainfracloud.org/results/ankursinha/rubygem-taskjuggler/fedora-rawhide-x86_64/08910683-rubygem-taskjuggler/builder-live.log.gz
>> Given the test case name:
>> 
>> ~~~
>> 
>>   2) TaskJuggler::StatusSheetTest TaskJuggler::StatusSheetSender should have
>> generated 1 mail
>> 
>> ~~~
>> And comparing with the last know Fedora version of the .spec:
>> 
>> https://src.fedoraproject.org/rpms/rubygem-taskjuggler/blob/20c97f4e0dbf3e5af96bb0688ef8256d467fe0e4/f/rubygem-taskjuggler.spec
>> 
>> Isn't the `BuildRequires: rubygem(mail)` what is missing?
>> 
>> And yes, there seems to be two parts of the test suite, one using
>> rubygem-rspec while the other seems to be using rubygem-test-unit (yes, the
>> former .spec file tried to convert the test suite to be executed by
>> Minitest, but don't do that, stay with rubygem-test-unit and save some
>> troubles to you). Executing the test/all.rb for the latter should be enough.
>
> I've disabled the tests at the moment, so that'll be the first thing
> I'll be working on for the re-review.

It builds with that patch.  With missing deps packaged, tests run and pass:
https://copr.fedorainfracloud.org/coprs/fed500/rubygem-taskjuggler/builds/

>
> The new version, 3.8.1, is out, and that's what the COPR is at. There
> are a few niggles with Ruby 3.4 at the moment from the looks of it[1],
> but upstream is responsive and aware, so they should be fixed soon. I
> did look into them, but they were beyond my limited Ruby-fu, so if any
> Ruby pros want to take a look and submit fixes upstream, that'll be
> great too:
>
> https://github.com/taskjuggler/TaskJuggler/issues/303
>
-- 
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to