On Mon, 2025-02-17 at 21:22 -0500, Dusty Mabe wrote:
> 
> On 2/17/25 1:35 PM, Adam Williamson wrote:
> > On Mon, 2025-02-17 at 10:35 -0500, Dusty Mabe wrote:
> > > > 
> > > >     One more question: are packagers able to restart the tests?
> > > > 
> > > > 
> > > > @Dusty Mabe <mailto:du...@dustymabe.com> will know better, but I don't 
> > > > think packagers can restart the tests currently.
> > > 
> > > No. Not currently. But it is something we could look into enabling and/or 
> > > making easier.
> > 
> > You might be surprised. It might actually work already without you
> > knowing it.
> > 
> > Clicking the "Re-Run Tests" button in Bodhi causes Bodhi to publish a
> > new bodhi.update.status.testing.koji-build-group.build.complete message
> > - which is the same topic I think I advised you to use for CoreOS
> > update test scheduling. The only difference between a 're-trigger'
> > message and the message that is published when the update is a key in
> > the message data called `re-trigger`. It's `true` for messages
> > published when "Re-Run Tests" is clicked, `false` otherwise.
> > 
> > If your scheduler triggers off `koji-build-group.build.complete`
> > messages and doesn't do anything special with the `re-trigger` key, it
> > probably works already.
> 
> Interesting. I'll have to look into it.
> 
> Does this have a side effect of causing all tests to re-run, even ones that 
> have already run and passed?

Unfortunately yeah. Well, more precisely, it depends on how your
scheduler behaves.

The `re-trigger` key is there so your scheduler *can*, if you like, be
smart about it: a scheduler could notice this is a re-run request and
say 'aha, ok, i'll only rerun failed tests'.

I haven't done this for the openQA scheduler yet as it's actually
rather tricky in that case (openQA doesn't have a handy 'just re-run
failures' option). But the possibility is there. If 'just re-run
failures' is easy in your case, might be worth hooking it up.
-- 
Adam Williamson (he/him/his)
Fedora QA
Fedora Chat: @adamwill:fedora.im | Mastodon: @ad...@fosstodon.org
https://www.happyassassin.net




-- 
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to