On Wed, Mar 27, 2024 at 08:32:41PM +0200, Otto Liljalaakso wrote: > > 27. maaliskuuta 2024 12.59.11 GMT+02:00 Petr Pisar <ppi...@redhat.com> > kirjoitti: > >V Tue, Mar 26, 2024 at 02:52:50PM +0100, Miroslav Suchý napsal(a): > >> I have no strong opinion how to process with the case of "MIT and BSD and > >> Bitstream Vera and OFL". I think that converting it to " MIT and BSD and > >> Bitstream-Vera and OFL" is probably best option. I.e. the License tag will > >> become mixture of Callaway and SPDX. It will not make it valid SPDX formula > >> so it will still pop up as package to be fixed, but at least some work will > >> be done. > > > >In other words, it will be a regression. Invalid by either system: > > > >$ license-validate 'MIT AND BSD AND Bitstream-Vera and OFL' > >Not a valid license string > >Run with -v option to see more information. > >$ license-validate --old 'MIT AND BSD AND Bitstream-Vera and OFL' > >Not a valid license string > >Run with -v option to see more information. > > > >I wouldn't do it. > > > >If you want to hint the packager, then open a pull request with the partial > >conversion. > > > >-- Petr > > I also think the conversion should only be done if the full License string > can be converted. Partial conversion is confusing, and there is not much > value, since trivial conversion is, well, trivial, and whoever will > eventually need to take a look at the nontrivial parts can easily handle it > then.
I'd add a "me too": I think if we have mixed spdx and callaways strings, this will make later automatic processing even harder. I that is possible, I think you should just do the full conversion for those packages, even if that requires some manual introspection. Zbyszek -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
