On 28. 02. 23 0:40, Miroslav Suchý wrote:
Dne 28. 02. 23 v 0:26 Jerry James napsal(a):
So I guess the script only checks the first line of the git commit
message, right?

Right. I thought that checking whole commit message may bring more false positives.

On one hand, I think the script should consider commits like this:

"""
Modernize packaging

Remove deprecated macros
Verify license is SPDX
Drop Fedora 28 conditionals
"""

On the other hand, I consider putting "Verified that License tag is valid SPDX." into a commit with "Use the %gap_arches macro." in the subject chaotic evil.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to