On Tue, Dec 13, 2022 at 4:40 AM Chris Kelley <ckel...@redhat.com> wrote: > Hello all! > > I recently took over maintaining the Jackson serialisation packages in Fedora > and I am rebasing them to the latest upstream version in a side-tag: > https://koji.fedoraproject.org/koji/builds?userID=ckelley&tagID=60533. I am > experiencing curious difficulties I am hoping someone may be able to shed > light on! > > Before attempting this update in Rawhide, I performed the update in copr: > https://copr.fedorainfracloud.org/coprs/ckelley/pki/packages/ > This, after a bit of trial-and-error, was successful - and these packages are > now being used successfully in the upstream CI for various packages. All good. > > Then, I attempted the same in Rawhide. The first 3 packages in the side-tag > (FYI first time side-tagging) build fine, but jackson-annotations does not: > https://koji.fedoraproject.org/koji/taskinfo?taskID=95305556 > The failure is strange as the dep that provides the code to understand bundle > packaging is present (and it works in copr). > > After a bit of frustration I stopped to focus on performing the same update > in CentOS 9 Stream, from the same sources. This update too was successful > (eventually, first side-tag there too). The spec files are essentially > identical between c9s and Rawhide, so I don't see an explanation there. > > Curiously, I submitted a later update to jackson-annotations in c9s and it > now fails with the exact same packaging problem as occurs in Rawhide. That > update contained only a RH internal test file, the sources and spec were > untouched. > > My theory is that there is a dependency that was updated in Rawhide, which is > problematic for my build, and that dep was recently updated in c9s and is now > causing the same problem for me there. Has anyone seen anything like this > before? How did you begin to investigate it? Or am I just being a side-tag > noob? > > Any help at all appreciated, thanks! > > Chris
Although the spec BRs mvn(org.apache.felix:maven-bundle-plugin), pom.xml doesn't mention it. Add this to %prep: %pom_add_plugin "org.apache.felix:maven-bundle-plugin:5.1.1" . "<extensions>true</extensions>" After doing that, the build still fails: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project jackson-annotations: Compilation failure: Compilation failure: [ERROR] Source option 6 is no longer supported. Use 7 or later. [ERROR] Target option 6 is no longer supported. Use 7 or later. So add this to %prep too: %pom_xpath_set "//pom:javac.src.version" "1.7" %pom_xpath_set "//pom:javac.target.version" "1.7" %pom_xpath_set "//pom:maven.compiler.source" "1.7" %pom_xpath_set "//pom:maven.compiler.target" "1.7" Also, patch 0001-Add-extensions-true-to-build-helper-maven-plugin.patch accomplishes nothing, since the build-helper plugin isn't installed, and all mention of it is removed in the 4th %pom_remove_plugin line in %prep. You may as well drop the patch. Merry winter holiday of your choice! -- Jerry James, who has been playing Christmas music for the last 4 weeks http://www.jamezone.org/ _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue