On Thu, 2019-01-17 at 18:20 +0100, Miro Hrončok wrote: > On 17. 01. 19 17:26, Adam Williamson wrote: > > If a project is enforcing sign-off but doesn't have > > the DCO or any other kind of prominent statement of what the sign-off > > is*for*, that is meaningless, because there's no reasonable context > > for the sign-off text. > > Exactly. > > Also, the text sometimes is a bit weird: > > (fedpkg as an example) > "All commits must be signed-off on. Please use git commit -s to do that. This > serves as a confirmation that you have the right to submit your changes. See > Developer Certificate of Origin for details." > > This should IMHO rather say something like: > > "We require all the contributors to agree with the Developer Certificate of > Origin. To confirm that you do, sign off your commits. Please use git commit > -s > to do that." > > > What bothers me that while I understand that there is some meaning for the > signed-off commits (however snake oil legalese it really appears), the > enforcement doesn't explain it and simply says: Sign off your commits! Do it! > You have to! > > And when you do, you do it because it's a technical requirement. You are not > aware that you are performing some kind of agreement with a legal document. > > > So to make this a bit better, can we change the enforcement wording on Pagure? > > Say: > > We require all the contributors to agree with the Developer Certificate of > Origin. To confirm that you do, sign off your commits. Please use git commit > -s > to do that. We unfortunately don't accept commits without that.
The problem is that git sign-off is a generic mechanism which isn't *necessarily* associated with the DCO. A project could choose to use some other similar mechanism and have sign-off be a signal of acceptance of *that* mechanism instead. Still, DCO seems to be the most popular by some way, so it might be worthwhile for Pagure to have some kind of specific support for it indeed. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
