I just add push label for it.
发件人: Hsueh, Hong-Chih (Neo) <hong-chih.hs...@amd.com> 发送时间: 2024年6月4日 23:46 收件人: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io; Chang, Abner <abner.ch...@amd.com> 抄送: michael.d.kin...@intel.com; zhiguang....@intel.com; He, Jiangang <jiangang...@amd.com> 主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) [AMD Official Use Only - AMD Internal Distribution Only] Hi Liming, Sorry for the late response. I already created a pull request for it. https://github.com/tianocore/edk2/pull/5737 Regards, Neo _____ From: gaoliming <gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn> > Sent: Wednesday, May 15, 2024 8:08 PM To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Chang, Abner <abner.ch...@amd.com <mailto:abner.ch...@amd.com> >; Hsueh, Hong-Chih (Neo) <hong-chih.hs...@amd.com <mailto:hong-chih.hs...@amd.com> > Cc: michael.d.kin...@intel.com <mailto:michael.d.kin...@intel.com> <michael.d.kin...@intel.com <mailto:michael.d.kin...@intel.com> >; zhiguang. l...@intel.com <mailto:zhiguang....@intel.com> <zhiguang....@intel.com <mailto:zhiguang....@intel.com> >; He, Jiangang <jiangang...@amd.com <mailto:jiangang...@amd.com> > Subject: 回复: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775) Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Abner: This change is good to me. Reviewed-by: Liming Gao <gaolim...@byosoft.com. cn <mailto:gaolim...@byosoft.com.cn> > But, this is not critical issue. So, I suggest to merge it after the stable tag. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 Chang, Abner via > groups.io > 发送时间: 2024年5月16日 8:50 > 收件人: Hsueh, Hong-Chih (Neo) <hong-chih.hs...@amd.com <mailto:Hong-Chih. hs...@amd.com> >; > devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 抄送: michael.d.kin...@intel.com <mailto:michael.d.kin...@intel.com> ; gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn> ; > zhiguang....@intel.com <mailto:zhiguang....@intel.com> ; He, Jiangang <jiangang...@amd.com <mailto:jiangang...@amd.com> > > 主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from > header file (BZ# 4775) > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Mike, Liming and Zhiguang, > Could you please check this patch sent two weeks ago? The corresponding BZ > ticket is 4775. We overlooked tracking this issue and missed the 202405 stable > release. As this impacts the build, do you think we can have a quick review and > approve it; having this change pulled in 202405 stable release? Otherwise we will > have to wait until next stable release. > > Thanks > Abner > > > -----Original Message----- > > From: Hsueh, Hong-Chih (Neo) <hong-chih.hs...@amd.com <mailto:Hong-Chih. hs...@amd.com> > > > Sent: Thursday, May 2, 2024 3:31 AM > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > > Cc: michael.d.kin...@intel.com <mailto:michael.d.kin...@intel.com> ; gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn> ; > > zhiguang....@intel.com <mailto:zhiguang....@intel.com> ; He, Jiangang <jiangang...@amd.com <mailto:jiangang...@amd.com> >; Chang, > > Abner <abner.ch...@amd.com <mailto:abner.ch...@amd.com> >; Hsueh, Hong-Chih (Neo) <Hong- > > chih.hs...@amd.com <mailto:chih.hs...@amd.com> > > > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file > > > > Cc: Jiangang He <jiangang...@amd.com <mailto:jiangang...@amd.com> > > > Signed-off-by: Neo Hsueh <hong-chih.hs...@amd.com <mailto:hong-chih.hs...@amd.com> > > > --- > > MdePkg/Include/Register/Amd/Cpuid.h | 4 ++-- > > MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 ++++---- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h > > b/MdePkg/Include/Register/Amd/Cpuid.h > > index add43c40aa..51fa9f235c 100644 > > --- a/MdePkg/Include/Register/Amd/Cpuid.h > > +++ b/MdePkg/Include/Register/Amd/Cpuid.h > > @@ -46,9 +46,9 @@ CPUID Signature Information > > CPUID Extended Topology Enumeration > > > > @note > > - Reference: AMD64 Architecture Programmer’s Manual Volume 3: General- > > Purpose and System Instructions, > > + Reference: AMD64 Architecture Programmer's Manual Volume 3: General- > > Purpose and System Instructions, > > Revision 3.35 Appendix E, > > - E.4.24 Function 8000_0026―Extended CPU Topology: > > + E.4.24 Function 8000_0026-Extended CPU Topology: > > CPUID Fn8000_0026 reports extended topology information for logical > > processors, including > > asymmetric and heterogenous topology descriptions. Individual logical > > processors may report > > different values in systems with asynchronous and heterogeneous > > topologies. > > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > index 756e7c86ec..4715c59dc4 100644 > > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h > > @@ -5733,9 +5733,9 @@ typedef union { > > /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms > enumerated > > in > > /// IA32_TME_CAPABILITY are allowed. > > /// For example: > > - /// 0000 �C AES-XTS-128. > > - /// 0001 �C AES-XTS-128 with integrity. > > - /// 0010 �C AES-XTS-256. > > + /// 0000 - AES-XTS-128. > > + /// 0001 - AES-XTS-128 with integrity. > > + /// 0010 - AES-XTS-256. > > /// Other values are invalid. > > /// > > UINT32 TmePolicy : 4; > > @@ -5756,7 +5756,7 @@ typedef union { > > /// Similar to enumeration, this is an encoded value. > > /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in > > #GP. > > /// Writing a non-zero value to this field will #GP if bit 1 of EAX (Hardware > > - /// Encryption Enable) is not also set to ‘1, as encryption hardware must > be > > + /// Encryption Enable) is not also set to 1, as encryption hardware must > be > > /// enabled to use MKTME. > > /// Example: To support 255 keys, this field would be set to a value of 8. > > /// > > -- > > 2.40.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119469): https://edk2.groups.io/g/devel/message/119469 Mute This Topic: https://groups.io/mt/106500097/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
