Yes. Mike
> -----Original Message----- > From: Kasbekar, Saloni <saloni.kasbe...@intel.com> > Sent: Thursday, May 30, 2024 10:39 AM > To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael D > <michael.d.kin...@intel.com>; Rebecca Cran <rebe...@bsdio.com>; > kra...@redhat.com; Kubacki, Michael <michael.kuba...@microsoft.com> > Subject: RE: [edk2-devel] GitHub PR Code Review process now active > > How are we planning to handle packages (like NetworkPkg) without a > maintainer? Would the stewards add in the reviewers in that case? > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > Kubacki > Sent: Wednesday, May 29, 2024 5:51 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; devel@edk2.groups.io; > Rebecca Cran <rebe...@bsdio.com>; kra...@redhat.com; Kubacki, Michael > <michael.kuba...@microsoft.com> > Subject: Re: [edk2-devel] GitHub PR Code Review process now active > > I've updated the wiki process to clarify that maintainers need to ensure PR > reviewers are added and that a contributor cannot do so unless they are a > maintainer in this update: > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development- > Process/_compare/b9d1f34e40d8ecbc7b59632302c9b0c823f52ab8...dd846b296754da310 > 03f8c2a70e9a0b861e600b6 > > I did not include the @<github> ID process since there was not clear > consensus on that. I think it's tedious and for this small window of time > without automation, ideally the GitHub notifications mentioned earlier can be > used. > > Thanks, > Michael > > On 5/29/2024 4:06 PM, Kinney, Michael D wrote: > > We could, but that would require manually syncing CODEOWNERS with > > Maintainer.txt until that part of the process is automated. > > > > We also need a way to verify that CODEOWNERS and Maintainers.txt > > produce the exact same assignments. > > > > This was on the list of future enhancements when resources are > > available to help. We need to focus on a process that works until > > those automations can be deployed and supported. > > > > Mike > > > >> -----Original Message----- > >> From: Michael Kubacki <mikub...@linux.microsoft.com> > >> Sent: Wednesday, May 29, 2024 12:25 PM > >> To: devel@edk2.groups.io; Kinney, Michael D > >> <michael.d.kin...@intel.com>; Rebecca Cran <rebe...@bsdio.com>; > >> kra...@redhat.com; Kubacki, Michael <michael.kuba...@microsoft.com> > >> Subject: Re: [edk2-devel] GitHub PR Code Review process now active > >> > >> Mike, > >> > >> I agree that automatically adding reviewers would be helpful. > >> > >> Do you think we could add a CODEOWNERS file now to assist with this? > >> > >> Benefits being: > >> > >> 1. CODEOWNERS is low overhead in that GitHub already supports it. > >> > >> 2. We do not need to require CODEOWNER enforcement yet. We can simply > >> use it for automating the process of adding maintainers. > >> > >> 3. Maintainers have write access so they are required to approve and > >> add the push label. This would add a relevant maintainer(s) with > >> write access to fulfill that role. > >> > >> Thanks, > >> Michael > >> > >> On 5/29/2024 2:27 PM, Michael D Kinney wrote: > >>> GitHub has notification settings. Maintainers should configure > >>> GitHub so they are notified of all PR submissions to edk2 repo. > >>> > >>> The Wiki for the Maintainer Process provides a link to this page > >>> with the > >> details: > >>> > >>> https://docs.github.com/en/account-and-profile/managing-subscription > >>> s-and- > >> notifications-on-github/setting-up-notifications/configuring-notifica > >> tions > >>> > >>> https://docs.github.com/en/account-and-profile/managing-subscription > >>> s-and- > >> notifications-on-github/setting-up-notifications/configuring- > >> notifications#about-custom-notifications > >>> > >>> This allows Maintainers to receive notifications without being an > >>> assigned reviewer. > >>> > >>> Mike > >>> > >>>> -----Original Message----- > >>>> From: Rebecca Cran <rebe...@bsdio.com> > >>>> Sent: Wednesday, May 29, 2024 11:19 AM > >>>> To: devel@edk2.groups.io; Kinney, Michael D > >>>> <michael.d.kin...@intel.com>; kra...@redhat.com; Kubacki, Michael > >>>> <michael.kuba...@microsoft.com> > >>>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active > >>>> > >>>> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote: > >>>>> Hi Gerd, > >>>>> > >>>>> We can clarify the Wiki. A Maintainer has to be involved in every > >>>>> code review. The first action a Maintainer does is verify that > >>>>> the code change should be considered at all or rejected. Then add > >>>>> maintainers for the ones that look like good submissions. > >>>>> > >>>>> I agree that this may add a bit of delay. You are welcome to add > >>>>> a comment with @<githubid> tags to the maintainers and reviewers > >>>>> so they know to look at it and do the assignments. If you like > >>>>> that idea we can add that to the Wiki as well. > >>>>> > >>>>> Since PRs can be also opened by outside contributors that have > >>>>> limited access, maintainers have to be involved in reviewing newly > >>>>> submitted PRs. > >>>> > >>>> "Then add maintainers for the ones that look like good submissions." > >>>> > >>>> Surely in order for the maintainers to know the PR should be looked > >>>> at in the first place they need to already be added? > >>>> > >>>> -- > >>>> > >>>> Rebecca Cran > >>> > >>> > >>> > >>> > >>> > >>> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119401): https://edk2.groups.io/g/devel/message/119401 Mute This Topic: https://groups.io/mt/106355103/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
