Hi Abner, Yes. The plan is to apply to all repos.
We want to use it on edk2 for a while to make sure we get the settings and process correct, then we will expand. Mike > -----Original Message----- > From: Chang, Abner <abner.ch...@amd.com> > Sent: Wednesday, May 29, 2024 3:41 AM > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kin...@intel.com> > Subject: RE: GitHub PR Code Review process now active > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Mike, > Wondering if we also plan to apply GitHub PR process on edk2-platforms repo? > Or other repos under tianocore? I found there is another email thread "Enable > GitHub PR, protected branches, and 'push' label" on edk2-platforms, but no > further discussions then. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D > > Kinney via groups.io > > Sent: Wednesday, May 29, 2024 2:54 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D <michael.d.kin...@intel.com> > > Subject: [edk2-devel] GitHub PR Code Review process now active > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > Hello, > > > > The GitHub PR code review process is now active. Please > > use the new PR based code review process for all new > > submissions starting today. > > > > * The Wiki has been updated with the process changes. > > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > > Development-Process > > > > Big thanks to Michael Kubacki for writing up all the > > changes based on the RFC proposal and community discussions. > > > > We will learn by using, so if you see anything missing or > > incorrect or clarifications needed, please send feedback > > here so the Wiki pages can be updated quickly for everyone. > > > > * The edk2 repo settings have been updated to require > > a GitHub PR code review approval before merging and > > all conversations must be resolved before merging. > > > > * A PR has been opened that removes the requirement for > > Cc: tags in the commit messages and is the first PR > > that will use the new process. This PR needs to be > > reviewed and merged to support the revised commit > > message format. > > > > https://github.com/tianocore/edk2/pull/5688 > > > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > > Format > > > > * Please use "Draft" PRs to run CI without any reviews. > > Once ready for reviews, convert from "Draft" to > > "Ready for Review". > > > > * For active code reviews that are almost complete and will > > be ready for merge in the next few days, the submitter may > > choose to either complete using the email review process, > > or switch to the PR based code review process. > > > > * For active code reviews that are expected to take more than > > a few days to complete, please convert to a PR based code review. > > > > Thanks, > > > > Mike > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119351): https://edk2.groups.io/g/devel/message/119351 Mute This Topic: https://groups.io/mt/106355103/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
