Hi Liming, Yes. We want to merge it immediately.
Thanks for your support! Thanks, Wenxing From: gaoliming <gaolim...@byosoft.com.cn> Sent: Monday, May 27, 2024 4:21 PM To: devel@edk2.groups.io; Hou, Wenxing <wenxing....@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; 'Andrew Fish' <af...@apple.com>; 'Leif Lindholm' <quic_llind...@quicinc.com> Cc: 'Ard Biesheuvel' <a...@kernel.org>; sam.kay...@arm.com; dougfl...@microsoft.com; Mathews, John <john.math...@intel.com>; Li, Yi1 <yi1...@intel.com>; Yao, Jiewen <jiewen....@intel.com> Subject: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405 Wenxing: If this patch is required to be merged immediately, I will help add push label. Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Wenxing Hou 发送时间: 2024年5月27日 12:24 收件人: gaoliming <gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; 'Andrew Fish' <af...@apple.com<mailto:af...@apple.com>>; 'Leif Lindholm' <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>> 抄送: 'Ard Biesheuvel' <a...@kernel.org<mailto:a...@kernel.org>>; sam.kay...@arm.com<mailto:sam.kay...@arm.com>; dougfl...@microsoft.com<mailto:dougfl...@microsoft.com>; Mathews, John <john.math...@intel.com<mailto:john.math...@intel.com>>; Li, Yi1 <yi1...@intel.com<mailto:yi1...@intel.com>>; Yao, Jiewen <jiewen....@intel.com<mailto:jiewen....@intel.com>> 主题: Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405 Hi Liming, Our PR: https://github.com/tianocore/edk2/pull/5645 need to be merged too. And the CryptoPkg maintainer Li Yi can not add the Push label. Could you please merge this PR? Thanks, Wenxing From: gaoliming <gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>> Sent: Tuesday, May 21, 2024 10:21 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hou, Wenxing <wenxing....@intel.com<mailto:wenxing....@intel.com>>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; 'Andrew Fish' <af...@apple.com<mailto:af...@apple.com>>; 'Leif Lindholm' <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>> Cc: 'Ard Biesheuvel' <a...@kernel.org<mailto:a...@kernel.org>>; sam.kay...@arm.com<mailto:sam.kay...@arm.com>; dougfl...@microsoft.com<mailto:dougfl...@microsoft.com>; Mathews, John <john.math...@intel.com<mailto:john.math...@intel.com>>; Li, Yi1 <yi1...@intel.com<mailto:yi1...@intel.com>>; Yao, Jiewen <jiewen....@intel.com<mailto:jiewen....@intel.com>> Subject: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405 Wenxing: We are in hard feature freeze phase. In this phase, only bug fixes will be accepted (https://github.com/tianocore/tianocore.github.io/wiki/HardFeatureFreeze). So, this patch set may be merged after the stable tag is created. Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Wenxing Hou 发送时间: 2024年5月17日 23:10 收件人: gaoliming <gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 'Andrew Fish' <af...@apple.com<mailto:af...@apple.com>>; 'Leif Lindholm' <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>> 抄送: 'Ard Biesheuvel' <a...@kernel.org<mailto:a...@kernel.org>>; sam.kay...@arm.com<mailto:sam.kay...@arm.com>; dougfl...@microsoft.com<mailto:dougfl...@microsoft.com>; Mathews, John <john.math...@intel.com<mailto:john.math...@intel.com>>; Li, Yi1 <yi1...@intel.com<mailto:yi1...@intel.com>>; Yao, Jiewen <jiewen....@intel.com<mailto:jiewen....@intel.com>> 主题: Re: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405 Hi Liming and Mike, For the PATCH: Add more crypt APIs based on Mbedtls (https://edk2.groups.io/g/devel/message/118772), I have fixed the code based on Mike’s feedback and added the platform integration test table in commit message. Could you approve this PATCH to catch this table tag? Thanks, Wenxing From: gaoliming <gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>> Sent: Wednesday, May 15, 2024 8:49 AM To: Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 'Andrew Fish' <af...@apple.com<mailto:af...@apple.com>>; 'Leif Lindholm' <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>> Cc: 'Ard Biesheuvel' <a...@kernel.org<mailto:a...@kernel.org>>; sam.kay...@arm.com<mailto:sam.kay...@arm.com>; dougfl...@microsoft.com<mailto:dougfl...@microsoft.com>; Mathews, John <john.math...@intel.com<mailto:john.math...@intel.com>>; Hou, Wenxing <wenxing....@intel.com<mailto:wenxing....@intel.com>>; Li, Yi1 <yi1...@intel.com<mailto:yi1...@intel.com>>; Yao, Jiewen <jiewen....@intel.com<mailto:jiewen....@intel.com>> Subject: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405 Mike: Thanks for your comments. I update the status below. Thanks Liming 发件人: Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>> 发送时间: 2024年5月15日 0:35 收件人: gaoliming <gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; 'Andrew Fish' <af...@apple.com<mailto:af...@apple.com>>; 'Leif Lindholm' <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>> 抄送: 'Ard Biesheuvel' <a...@kernel.org<mailto:a...@kernel.org>>; sam.kay...@arm.com<mailto:sam.kay...@arm.com>; dougfl...@microsoft.com<mailto:dougfl...@microsoft.com>; Mathews, John <john.math...@intel.com<mailto:john.math...@intel.com>>; Hou, Wenxing <wenxing....@intel.com<mailto:wenxing....@intel.com>>; Li, Yi1 <yi1...@intel.com<mailto:yi1...@intel.com>>; Yao, Jiewen <jiewen....@intel.com<mailto:jiewen....@intel.com>>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>> 主题: RE: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405 Hi Liming, My responses below in [Mike]. Mike From: gaoliming <gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn>> Sent: Friday, May 10, 2024 8:29 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; 'Andrew Fish' <af...@apple.com<mailto:af...@apple.com>>; 'Leif Lindholm' <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>> Cc: 'Ard Biesheuvel' <a...@kernel.org<mailto:a...@kernel.org>>; sam.kay...@arm.com<mailto:sam.kay...@arm.com>; dougfl...@microsoft.com<mailto:dougfl...@microsoft.com>; Mathews, John <john.math...@intel.com<mailto:john.math...@intel.com>>; Hou, Wenxing <wenxing....@intel.com<mailto:wenxing....@intel.com>> Subject: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405 Stewards: Now, there are several patches to catch this table tag. Could you give the comments for them? 1. Adding support for verbose UEFI Table dumping to Dmem.c (https://edk2.groups.io/g/devel/message/118582) [Liming] This patch set has been reviewed before soft feature freeze. It plans to catch this stable tag. [Mike] I see this PR: https://github.com/tianocore/edk2/pull/5653 that is not passing CI and appears it will require additional code changes [Mike] Reject for edk2-stable202405 2. MdePkg/BaseLib: Fix AARCH64 compilation error (https://edk2.groups.io/g/devel/message/118690) [Liming] This bug fix is reviewed in soft feature freeze phase. It plans to catch this stable tag. [Mike] Approved for edk2-stable202405 [Liming] I add push label for https://github.com/tianocore/edk2/pull/5642 3. MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount (https://edk2.groups.io/g/devel/message/118745) [Liming] This security fix is reviewed in soft feature freeze phase. It plans to catch this stable tag. [Mike] Approved for edk2-stable202405 [Liming] I add push label for https://github.com/tianocore/edk2/pull/5659 4. NetworkPkg: CVE-2023-45236 and CVE-2023-45237 (https://edk2.groups.io/g/devel/message/118768) [Liming] This security fix is still under code review. It plans to catch this stable tag. [Mike] Is the code review complete? Is there a link to the PR? [Liming] NetworkPkg reviewer will review this patch set this week. Thanks 5. Add more crypt APIs based on Mbedtls (https://edk2.groups.io/g/devel/message/118772) [Liming] This patch set passes code review in soft feature freeze phase. It plans to catch this stable tag. [Mike] This patch series uses ‘..’ in INF to access source files in another component. This is not legal. I am surprised this was not caught in code review. DEFINE OPENSSL_PATH = ../OpensslLib/openssl DEFINE BASE_CRYPT_PATH = ../BaseCryptLib [Mike] I see a reference to some “platform integration” testing. Given that this patch series implements a number of crypto service APIs and is a large number of new lines of code, it would be good to know if all of the newly added APIs were tested in a platform integration. A table of the added APIs and the platform integration test status would be good to know if there was any functional testing of each API. If there are APIs that are not covered by any platform integration testing, then I would be concerned with such a large change with limited testing. Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 gaoliming via groups.io 发送时间: 2024年5月7日 9:25 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; annou...@edk2.groups.io<mailto:annou...@edk2.groups.io> 抄送: 'Michael D Kinney' <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; 'Andrew Fish' <af...@apple.com<mailto:af...@apple.com>>; 'Leif Lindholm' <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>> 主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405 Hi, all We enter into Soft Feature Freeze phase now. In this phase, the feature under review will not be allowed to be pushed. The feature passed review can still be merged. The patch review can continue without break in edk2 community. If the patch is sent before Soft Feature Freeze, and plans to catch this stable tag, the patch contributor need reply to his patch and notify edk2 community. If the patch is sent after Soft Feature Freeze, and plans to catch this stable tag, please add edk2-stable202405 key words in the patch title and BZ, so the community know this patch target and give the feedback. To avoid the unnecessary changes to be merged in edk2 stable tag release, all edk2 maintainers' write access will be temporarily disabled until stable tag is released on 05-24. That means edk2 maintainer can't set push label in pull request after soft feature freeze starts. If the change wants to catch this stable tag 202405, please follow above rules, then send the merge request to gaolim...@byosoft.com.cn<mailto:gaolim...@byosoft.com.cn> or michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>. We will help merge the code change in soft feature freeze and hard feature freeze phase. Below is edk2-stable202405 tag planning Proposed Schedule Date (00:00:00 UTC-8) Description 2024-02-23 Beginning of development 2024-05-06 Soft Feature Freeze 2024-05-10 Hard Feature Freeze 2024-05-24 Release Thanks Liming -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119280): https://edk2.groups.io/g/devel/message/119280 Mute This Topic: https://groups.io/mt/106326964/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
