Happy to merge this. Liming, please let me know if this meets the soft freeze requirements?
Thanks, On Tue, 7 May 2024 at 07:18, Wu, Jiaxin <jiaxin...@intel.com> wrote: > > Thanks Jiewen. > > > > > > > > From: Yao, Jiewen <jiewen....@intel.com> > Sent: Tuesday, May 7, 2024 12:59 PM > To: Wu, Jiaxin <jiaxin...@intel.com>; Ni, Ray <ray...@intel.com>; > devel@edk2.groups.io; Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Zeng, Star <star.z...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; > Kumar, Rahul R <rahul.r.ku...@intel.com>; Dong, Guo <guo.d...@intel.com>; > Rhodes, Sean <sean@starlabs.systems>; Lu, James <james...@intel.com>; Guo, > Gua <gua....@intel.com>; Abdul Lateef Attar <abdullateef.at...@amd.com>; > Abner Chang <abner.ch...@amd.com>; Tom Lendacky <thomas.lenda...@amd.com> > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > Acked-by: Jiewen Yao <jiewen....@intel.com> > > > > From: Wu, Jiaxin <jiaxin...@intel.com> > Sent: Tuesday, May 7, 2024 11:39 AM > To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Yao, Jiewen <jiewen....@intel.com> > Cc: Zeng, Star <star.z...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; > Kumar, Rahul R <rahul.r.ku...@intel.com>; Dong, Guo <guo.d...@intel.com>; > Rhodes, Sean <sean@starlabs.systems>; Lu, James <james...@intel.com>; Guo, > Gua <gua....@intel.com>; Abdul Lateef Attar <abdullateef.at...@amd.com>; > Abner Chang <abner.ch...@amd.com>; Tom Lendacky <thomas.lenda...@amd.com> > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > Hi Jiewen and Ard, > > > > @Yao, Jiewen, @Ard Biesheuvel, do you agree we merge the change related to > OVMF package since you are the OVMF maintainers. Please help check /review. > > > > The patches have been acked/tested by the Gerd. > > > > [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for OVMF > [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > [PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation > [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done > or not > [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > > > Thanks, > > Jiaxin > > > > From: Wu, Jiaxin > Sent: Tuesday, April 30, 2024 6:14 PM > To: Ni, Ray <ray...@intel.com>; devel@edk2.groups.io > Cc: Zeng, Star <star.z...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; > Kumar, Rahul R <rahul.r.ku...@intel.com>; Dong, Guo <guo.d...@intel.com>; > Rhodes, Sean <sean@starlabs.systems>; Lu, James <james...@intel.com>; Guo, > Gua <gua....@intel.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>; Yao, > Jiewen <jiewen....@intel.com>; Abdul Lateef Attar > <abdullateef.at...@amd.com>; Abner Chang <abner.ch...@amd.com>; Tom Lendacky > <thomas.lenda...@amd.com> > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > Thanks Ray, I missed to add some already reviewed-by tag in v4. All V4 > patches are tested & acted by Gerd: > > Tested-by: Gerd Hoffmann <kra...@redhat.com> > > Acked-by: Gerd Hoffmann <kra...@redhat.com> > > > > For each one: listed as below, *so need Ray “reviewed-by” tag on the patch: > 05/06/14, need Gerd “reviewed-by” tag on the patch: 08/09/10/11/12* > > > > [PATCH v4 01/14] UefiCpuPkg: Add SmmRelocationLib class > > Reviewed-by: Ray Ni <ray...@intel.com> --> no change compared to V3 > > > [PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library > instance > > Reviewed-by: Ray Ni <ray...@intel.com> --> no change compared to V3 > > > [PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variables > > Reviewed-by: Ray Ni <ray...@intel.com> --> no change compared to V3 > > > [PATCH v4 04/14] UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory > allocation > > Reviewed-by: Ray Ni <ray...@intel.com> --> no change compared to V3 > > > [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary global > variable > [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex > > * Change Based on Ray’s comment on V3: split the removal of CpuIndex > parameter in a new patch, so add the 06 patch in V4.* > > > [PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance for AMD > > Reviewed-by: Abdul Lateef Attar <abdullateef.at...@amd.com> --> no change > compared to V3 > > > [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for OVMF > [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > [PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation > [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done > or not > [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > *Change Based on Gerd’s comment on V3: 1. Creating the > EFI_SMM_SMRAM_MEMORY_GUID HOB should be moved to its own function. 2) refine > the comment in SmmAccess 3) refine the commit log.* > > > [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib > > Reviewed-by: Gua Guo <gua....@intel.com> > > Reviewed-by: Guo Dong <guo.d...@intel.com> > > > [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic > > *Change Based on Ray’s comment on V3: move the "TileSize" check just below > the original TileSize calculation logic* > > > > Thanks, > > Jiaxin > > > > From: Ni, Ray <ray...@intel.com> > Sent: Tuesday, April 30, 2024 2:01 PM > To: Wu, Jiaxin <jiaxin...@intel.com>; devel@edk2.groups.io > Cc: Zeng, Star <star.z...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; > Kumar, Rahul R <rahul.r.ku...@intel.com>; Dong, Guo <guo.d...@intel.com>; > Rhodes, Sean <sean@starlabs.systems>; Lu, James <james...@intel.com>; Guo, > Gua <gua....@intel.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>; Yao, > Jiewen <jiewen....@intel.com>; Abdul Lateef Attar > <abdullateef.at...@amd.com>; Abner Chang <abner.ch...@amd.com>; Tom Lendacky > <thomas.lenda...@amd.com> > Subject: Re: [PATCH v4 00/14] Add SmmRelocationLib > > > > Jiaxin, > > You need to add the missing Reviewed-by for each patch if the patch doesn't > change in V4. > > > > Can you reply to this mail to list what patches have already got Reviewed-by > from whom? > > > > > > > > Thanks, > > Ray > > ________________________________ > > From: Wu, Jiaxin <jiaxin...@intel.com> > Sent: Friday, April 26, 2024 20:17 > To: devel@edk2.groups.io <devel@edk2.groups.io> > Cc: Ni, Ray <ray...@intel.com>; Zeng, Star <star.z...@intel.com>; Gerd > Hoffmann <kra...@redhat.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; Dong, > Guo <guo.d...@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James > <james...@intel.com>; Guo, Gua <gua....@intel.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Yao, Jiewen <jiewen....@intel.com>; Abdul Lateef > Attar <abdullateef.at...@amd.com>; Abner Chang <abner.ch...@amd.com>; Tom > Lendacky <thomas.lenda...@amd.com> > Subject: [PATCH v4 00/14] Add SmmRelocationLib > > > > PR: https://github.com/tianocore/edk2/pull/5546 > > Intel plans to separate the smbase relocation logic from > PiSmmCpuDxeSmm driver, and the related behavior will be > moved to the new interface defined by the SmmRelocationLib > class. > > The SmmRelocationLib class provides the SmmRelocationInit() > interface for platform to do the smbase relocation, which > shall provide below 2 functionalities: > 1. Relocate smbases for each processor. > 2. Create the gSmmBaseHobGuid HOB. > > With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at > a later phase) can be simplfied as below for SMM init: > 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases > for each Processor. > 2. Execute the early SMM Init. > > Cc: Ray Ni <ray...@intel.com> > Cc: Zeng Star <star.z...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Cc: Guo Dong <guo.d...@intel.com> > Cc: Sean Rhodes <sean@starlabs.systems> > Cc: James Lu <james...@intel.com> > Cc: Gua Guo <gua....@intel.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Abdul Lateef Attar <abdullateef.at...@amd.com> > Cc: Abner Chang <abner.ch...@amd.com> > Cc: Tom Lendacky <thomas.lenda...@amd.com> > Signed-off-by: Jiaxin Wu <jiaxin...@intel.com> > > Jiaxin Wu (14): > UefiCpuPkg: Add SmmRelocationLib class > UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance > UefiCpuPkg/SmmRelocationLib: Rename global variables > UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation > UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable > UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex > UefiCpuPkg/SmmRelocationLib: Add library instance for AMD > OvmfPkg/SmmRelocationLib: Add library instance for OVMF > OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > OvmfPkg: Refine SmmAccess implementation > OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not > OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib > UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic > > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 135 +++-- > .../Library/PlatformInitLib/PlatformInitLib.inf | 6 +- > .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 33 +- > .../Library/SmmRelocationLib}/Ia32/Semaphore.c | 13 +- > .../Library/SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- > .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ > .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 > +++++++++++++++++++++ > .../Library/SmmRelocationLib/SmmRelocationLib.inf | 60 +++ > .../SmmRelocationLib/SmramSaveStateConfig.c | 100 ++++ > .../Library/SmmRelocationLib}/X64/Semaphore.c | 13 +- > .../Library/SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- > OvmfPkg/Microvm/MicrovmX64.dsc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/PlatformPei/Platform.c | 3 + > OvmfPkg/PlatformPei/Platform.h | 5 + > OvmfPkg/PlatformPei/PlatformPei.inf | 5 +- > OvmfPkg/PlatformPei/SmmRelocation.c | 80 +++ > OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 4 +- > OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 5 + > OvmfPkg/SmmAccess/SmmAccessPei.c | 116 ++--- > OvmfPkg/SmmAccess/SmmAccessPei.inf | 11 +- > OvmfPkg/SmmAccess/SmramInternal.c | 72 +-- > OvmfPkg/SmmAccess/SmramInternal.h | 19 +- > UefiCpuPkg/Include/Library/SmmRelocationLib.h | 42 ++ > .../SmmRelocationLib/AmdSmmRelocationLib.inf | 60 +++ > .../SmmRelocationLib/AmdSmramSaveStateConfig.c | 125 +++++ > .../SmmRelocationLib}/Ia32/Semaphore.c | 13 +- > .../SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- > .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ > .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 > +++++++++++++++++++++ > .../Library/SmmRelocationLib/SmmRelocationLib.inf | 61 +++ > .../SmmRelocationLib/SmramSaveStateConfig.c | 136 +++++ > .../SmmRelocationLib}/X64/Semaphore.c | 13 +- > .../SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 21 +- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 334 ++----------- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 103 +--- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 4 - > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 69 --- > UefiCpuPkg/UefiCpuPkg.dec | 3 + > UefiCpuPkg/UefiCpuPkg.dsc | 2 + > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 + > 48 files changed, 2578 insertions(+), 796 deletions(-) > copy {UefiCpuPkg/PiSmmCpuDxeSmm => > OvmfPkg/Library/SmmRelocationLib}/Ia32/Semaphore.c (71%) > copy {UefiCpuPkg/PiSmmCpuDxeSmm => > OvmfPkg/Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%) > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h > create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.c > create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.inf > create mode 100644 OvmfPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c > copy {UefiCpuPkg/PiSmmCpuDxeSmm => > OvmfPkg/Library/SmmRelocationLib}/X64/Semaphore.c (78%) > copy {UefiCpuPkg/PiSmmCpuDxeSmm => > OvmfPkg/Library/SmmRelocationLib}/X64/SmmInit.nasm (59%) > create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c > create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocationLib.inf > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveStateConfig.c > rename UefiCpuPkg/{PiSmmCpuDxeSmm => > Library/SmmRelocationLib}/Ia32/Semaphore.c (71%) > rename UefiCpuPkg/{PiSmmCpuDxeSmm => > Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%) > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h > create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c > create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.inf > create mode 100644 UefiCpuPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c > rename UefiCpuPkg/{PiSmmCpuDxeSmm => > Library/SmmRelocationLib}/X64/Semaphore.c (78%) > rename UefiCpuPkg/{PiSmmCpuDxeSmm => > Library/SmmRelocationLib}/X64/SmmInit.nasm (59%) > > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118697): https://edk2.groups.io/g/devel/message/118697 Mute This Topic: https://groups.io/mt/105748911/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
