[AMD Official Use Only - General] Hi Ard,
Agree with you, reverting code looks not a good way now. We will think about new method to resolve this issue. Just need a bit more time and I will hold on checking in code to VanGoghBoard before it. Thanks again for your suggestion and help us improve code in VanGoghBoard. Thanks, Eric > -----Original Message----- > From: Ard Biesheuvel <a...@kernel.org> > Sent: Friday, April 19, 2024 5:25 PM > To: Xing, Eric <eric.x...@amd.com> > Cc: devel@edk2.groups.io; Zhai, MingXin (Duke) <duke.z...@amd.com>; > Lendacky, Thomas <thomas.lenda...@amd.com>; Chang, Abner > <abner.ch...@amd.com>; Yao, Ken <ken....@amd.com>; Roth, Michael > <michael.r...@amd.com>; Attar, AbdulLateef (Abdul Lateef) > <abdullateef.at...@amd.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Gerd Hoffmann <kra...@redhat.com>; Min > Xu <min.m...@intel.com>; Leif Lindholm <quic_llind...@quicinc.com> > Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to > required DSC files > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On Fri, 19 Apr 2024 at 11:06, Xing, Eric <eric.x...@amd.com> wrote: > > > > [AMD Official Use Only - General] > > > > Hi Ard, > > > > This checkin causes VanGoghBoard build fail now. Would you help revert it? > > I will merge PATCH to VanGoghBoard after the code review process done > and code changes are verified pass on real board. > > > > Please provide a solution instead that makes upstream edk2 work with > upstream edk2-platforms. > > For downstream builds, you can combine the old EDK2_202208 with an older > checkout of edk2-platforms, right? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118019): https://edk2.groups.io/g/devel/message/118019 Mute This Topic: https://groups.io/mt/105537744/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
