[AMD Official Use Only - General]
Thanks Duke. Hi Thomas, PATCH1/2 still cannot be checked in because today’s VanGoghBoard is based off EDK2_202208. Please hold on this PATCH check in. Added my comments below. Thanks, Eric > -----Original Message----- > From: Zhai, MingXin (Duke) <duke.z...@amd.com> > Sent: Friday, April 19, 2024 3:06 PM > To: Lendacky, Thomas <thomas.lenda...@amd.com>; Xing, Eric > <eric.x...@amd.com>; Chang, Abner <abner.ch...@amd.com>; Yao, Ken > <ken....@amd.com>; devel@edk2.groups.io > Cc: Roth, Michael <michael.r...@amd.com>; Attar, AbdulLateef (Abdul > Lateef) <abdullateef.at...@amd.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Gerd Hoffmann <kra...@redhat.com>; Min > Xu <min.m...@intel.com>; Leif Lindholm <quic_llind...@quicinc.com>; Leif > Lindholm <quic_llind...@quicinc.com> > Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC > files > > [AMD Official Use Only - General] > > Hi Thomas, > > Yes, I agree with your opinion, edk2-platforms should be able to build > against the latest edk2 repo. That is why we plan to update VanGoghBoard to > support latest EDK2, In fact we are doing QA testing. [Xing, Eric] It is incorrect for edk2-platforms board code. We will not verify edk2-platform build test with latest edk2. See my comments below. > I think every change on VanGoghBoard need ensure system can works > properly. But if I apply this patch and use the latest EDK2 version to build, > it > will encounter error because it requires other code changes(Such as including > new libraries). > So my point is, Let me upload VanGoghBoard related changes after passing > full QA testing. > > > Thanks! > > -----Original Message----- > From: Lendacky, Thomas > <thomas.lenda...@amd.com<mailto:thomas.lenda...@amd.com>> > Sent: Friday, April 19, 2024 12:03 AM > To: Zhai, MingXin (Duke) <duke.z...@amd.com<mailto:duke.z...@amd.com>>; Xing, > Eric > <eric.x...@amd.com<mailto:eric.x...@amd.com>>; Chang, Abner > <abner.ch...@amd.com<mailto:abner.ch...@amd.com>>; Yao, Ken > <ken....@amd.com<mailto:ken....@amd.com>> > Cc: Roth, Michael <michael.r...@amd.com<mailto:michael.r...@amd.com>>; Attar, > AbdulLateef (Abdul > Lateef) <abdullateef.at...@amd.com<mailto:abdullateef.at...@amd.com>> > Subject: Re: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC > files > > On 4/18/24 05:02, Zhai, MingXin (Duke) wrote: > > [AMD Official Use Only - General] > > > > Hi Thomas, > > > > this patch looks like for newer EDK2 codebase, but VanGoghBoard is based > on EDK2_202208 now, and will encounter build issues if this patch is applied. > > We have plans to update the EDK2 codebase to EDK2_202402. So I thought > > it would be better to add this change when we update the EDK2 code > > base😊 > > I thought the latest edk2-platforms repo was supposed to be able to build > against the latest edk2 repo. [Xing, Eric] No. It will easily impact edk2-platforms BIOS if we pull in the latest edk2 repo. So, edk2-platforms will pull in a stable edk2 tag instead of latest edk2 repo. >If your VanGoghBoard is based on a particular > edk2 tag, then you should probably have a tag in edk2-platforms so that you > can have a version of the edk2-platform code that works with a version of > the edk2 code, no? [Xing, Eric] I don’t think we will create tag for VanGoghBoard. Instead, we will have user guide/readme to let user know which EDK2 tag is supported in current board code. The board code owner can decide when to update edk2 kernel and which Tage. I think it is the same for ALL board code, not only VanGoghBoard. > > Why is this a private email? This discussion should be on the list so that the > maintainer(s) can decide what to do based on the discussion. > > Thanks, > Tom > > > > > > > Thanks! > > > > -----Original Message----- > > From: Xing, Eric <eric.x...@amd.com<mailto:eric.x...@amd.com>> > > Sent: Thursday, April 18, 2024 9:54 AM > > To: Chang, Abner <abner.ch...@amd.com<mailto:abner.ch...@amd.com>>; > > Lendacky, Thomas > > <thomas.lenda...@amd.com<mailto:thomas.lenda...@amd.com>>; > > devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Zhai, MingXin > (Duke) > > <duke.z...@amd.com<mailto:duke.z...@amd.com>>; Yao, Ken > > <ken....@amd.com<mailto:ken....@amd.com>> > > Cc: Ard Biesheuvel > > <ardb+tianoc...@kernel.org<mailto:ardb+tianoc...@kernel.org>>; Gerd Hoffmann > > <kra...@redhat.com<mailto:kra...@redhat.com>>; Roth, Michael > > <michael.r...@amd.com<mailto:michael.r...@amd.com>>; Min Xu > > <min.m...@intel.com<mailto:min.m...@intel.com>>; Leif Lindholm > > <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>>; > > Michael D Kinney > > <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; Attar, > > AbdulLateef > > (Abdul Lateef) <abdullateef.at...@amd.com<mailto:abdullateef.at...@amd.com>> > > Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC > > files > > > > [AMD Official Use Only - General] > > > > Thanks Thomas and Abner. > > Reviewed-by: <eric.x...@amd.com<mailto:eric.x...@amd.com>> > > > > For up-stream, please let us verify it first: > > @Zhai, MingXin (Duke), Duke, please help verify this change on Chachani > Board and feedback. > > > > Thanks, > > Eric > > > >> -----Original Message----- > >> From: Chang, Abner <abner.ch...@amd.com<mailto:abner.ch...@amd.com>> > >> Sent: Thursday, April 18, 2024 8:59 AM > >> To: Lendacky, Thomas > >> <thomas.lenda...@amd.com<mailto:thomas.lenda...@amd.com>>; > devel@edk2.groups.io<mailto:devel@edk2.groups.io> > >> Cc: Ard Biesheuvel > >> <ardb+tianoc...@kernel.org<mailto:ardb+tianoc...@kernel.org>>; Gerd > >> Hoffmann > >> <kra...@redhat.com<mailto:kra...@redhat.com>>; Roth, Michael > >> <michael.r...@amd.com<mailto:michael.r...@amd.com>>; Min Xu > >> <min.m...@intel.com<mailto:min.m...@intel.com>>; Leif Lindholm > >> <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>>; > >> Michael D Kinney > >> <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; Attar, > >> AbdulLateef > >> (Abdul > >> Lateef) <abdullateef.at...@amd.com<mailto:abdullateef.at...@amd.com>>; > >> Xing, Eric <eric.x...@amd.com<mailto:eric.x...@amd.com>> > >> Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required > DSC > >> files > >> > >> [AMD Official Use Only - General] > >> > >> Reviewed-by: <abner.ch...@amd.com<mailto:abner.ch...@amd.com>> > >> > >> Thanks > >> > >>> -----Original Message----- > >>> From: Lendacky, Thomas > >>> <thomas.lenda...@amd.com<mailto:thomas.lenda...@amd.com>> > >>> Sent: Monday, April 15, 2024 11:01 PM > >>> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > >>> Cc: Ard Biesheuvel > >>> <ardb+tianoc...@kernel.org<mailto:ardb+tianoc...@kernel.org>>; Gerd > >>> Hoffmann > >>> <kra...@redhat.com<mailto:kra...@redhat.com>>; Roth, Michael > >>> <michael.r...@amd.com<mailto:michael.r...@amd.com>>; Min > Xu > >>> <min.m...@intel.com<mailto:min.m...@intel.com>>; Leif Lindholm > >>> <quic_llind...@quicinc.com<mailto:quic_llind...@quicinc.com>>; > >>> Michael D Kinney > >>> <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; Chang, > >>> Abner > >>> <abner.ch...@amd.com<mailto:abner.ch...@amd.com>>; Attar, AbdulLateef > >>> (Abdul Lateef) > >>> <abdullateef.at...@amd.com<mailto:abdullateef.at...@amd.com>>; Xing, Eric > >>> <eric.x...@amd.com<mailto:eric.x...@amd.com>> > >>> Subject: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC > >>> files > >>> > >>> Any DSC file that uses the UefiCpuPkg MpInitLib library now requires > >>> the AmdSvsmLib library. Update the DSC files to include the > >>> AmdSvsmLib NULL library implementation. Also, fix the specification > >>> of VmgExitLib as it was renamed to CcExitLib. > >>> > >>> Cc: Abner Chang <abner.ch...@amd.com<mailto:abner.ch...@amd.com>> > >>> Cc: Abdul Lateef Attar <abdat...@amd.com<mailto:abdat...@amd.com>> > >>> Cc: Eric Xing <eric.x...@amd.com<mailto:eric.x...@amd.com>> > >>> Signed-off-by: Tom Lendacky > >>> <thomas.lenda...@amd.com<mailto:thomas.lenda...@amd.com>> > >>> --- > >>> Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >>> diff --git > a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc > >>> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc > >>> index 20f06dd851..e478e0b0c2 100644 > >>> --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc > >>> +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc > >>> @@ -371,7 +371,8 @@ > >>> > >>> [LibraryClasses.common] > >>> > >>> RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilte > >>> RegisterFilterLib|rL > >>> RegisterFilterLib|ibNull.inf > >>> - VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf > >>> + CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf > >>> + > AmdSvsmLib|UefiCpuPkg/Library/AmdSvsmLibNull/AmdSvsmLibNull.inf > >>> > >>> [PcdsFixedAtBuild] > >>> > >> > gEfiAmdAgesaPkgTokenSpaceGuid.PcdFchOemBeforePciRestoreSwSmi|0xE > A > >>> -- > >>> 2.43.2 > >> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118009): https://edk2.groups.io/g/devel/message/118009 Mute This Topic: https://groups.io/mt/105537744/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
