Ashraf: I just merge it. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ashraf Ali S > 发送时间: 2024年4月17日 16:36 > 收件人: devel@edk2.groups.io; S, Ashraf Ali <ashraf.al...@intel.com>; Chen, > Christine <yuwei.c...@intel.com>; Rebecca Cran <rebe...@bsdio.com>; > Liming Gao <gaolim...@byosoft.com.cn> > 抄送: Feng, Bob C <bob.c.f...@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com> > 主题: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while > parsing FMMTConfig.ini > > Hi @Liming Gao @Rebecca Cran > > Is this patch already pushed? As its been already reviewed. > > Thanks., > S, Ashraf Ali > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashraf Ali > S > Sent: Monday, March 11, 2024 5:01 PM > To: devel@edk2.groups.io; Chen, Christine <yuwei.c...@intel.com> > Cc: Rebecca Cran <rebe...@bsdio.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Feng, Bob C <bob.c.f...@intel.com>; > Chaganty, Rangasai V <rangasai.v.chaga...@intel.com> > Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while > parsing FMMTConfig.ini > > Thanks for the review. > > I have triggered the PR under basetools : > https://github.com/tianocore/edk2-basetools/pull/122 > > Thanks., > S, Ashraf Ali > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei > Chen > Sent: Monday, March 11, 2024 1:22 PM > To: S, Ashraf Ali <ashraf.al...@intel.com>; devel@edk2.groups.io > Cc: Rebecca Cran <rebe...@bsdio.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Feng, Bob C <bob.c.f...@intel.com>; > Chaganty, Rangasai V <rangasai.v.chaga...@intel.com> > Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while > parsing FMMTConfig.ini > > Ali, please also create PR in BaseTools repo. > Reviewed-by: Yuwei Chen <yuwei.c...@intel.com> > > > -----Original Message----- > > From: S, Ashraf Ali <ashraf.al...@intel.com> > > Sent: Wednesday, February 28, 2024 5:57 PM > > To: devel@edk2.groups.io > > Cc: S, Ashraf Ali <ashraf.al...@intel.com>; Rebecca Cran > > <rebe...@bsdio.com>; Liming Gao <gaolim...@byosoft.com.cn>; Feng, > Bob > > C <bob.c.f...@intel.com>; Chen, Christine <yuwei.c...@intel.com>; > > Chaganty, Rangasai V <rangasai.v.chaga...@intel.com> > > Subject: [PATCH] BaseTools: FMMT Skip empty Lines while parsing > > FMMTConfig.ini > > > > When the FMMTConf.ini file has empty lines then it used to throw > > errors GuidTool load error!, this patch is to skip checking for empty > > lines in the ini file > > > > Cc: Rebecca Cran <rebe...@bsdio.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Bob Feng <bob.c.f...@intel.com> > > Cc: Yuwei Chen <yuwei.c...@intel.com> > > Cc: Chen Christine <yuwei.c...@intel.com> > > Cc: Chaganty Rangasai V <rangasai.v.chaga...@intel.com> > > > > Signed-off-by: Ashraf Ali <ashraf.al...@intel.com> > > --- > > BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py > > b/BaseTools/Source/Python/FMMT/core/GuidTools.py > > index f6bdeffa50..f9cfd4ead0 100644 > > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py > > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py > > @@ -153,7 +153,7 @@ class GUIDTools: > > config_data = fd.readlines() > > for line in config_data: > > try: > > - if not line.startswith("#"): > > + if not line.startswith("#") and line.strip(): > > guid, short_name, command = line.split() > > new_format_guid = > > struct2stream(ModifyGuidFormat(guid.strip())) > > self.tooldef[new_format_guid] = GUIDTool( > > -- > > 2.42.0.windows.2 > > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117918): https://edk2.groups.io/g/devel/message/117918 Mute This Topic: https://groups.io/mt/105575993/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
