Thanks for the review. I have triggered the PR under basetools : https://github.com/tianocore/edk2-basetools/pull/122
Thanks., S, Ashraf Ali -----Original Message----- From: [email protected] <[email protected]> On Behalf Of Yuwei Chen Sent: Monday, March 11, 2024 1:22 PM To: S, Ashraf Ali <[email protected]>; [email protected] Cc: Rebecca Cran <[email protected]>; Liming Gao <[email protected]>; Feng, Bob C <[email protected]>; Chaganty, Rangasai V <[email protected]> Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini Ali, please also create PR in BaseTools repo. Reviewed-by: Yuwei Chen <[email protected]> > -----Original Message----- > From: S, Ashraf Ali <[email protected]> > Sent: Wednesday, February 28, 2024 5:57 PM > To: [email protected] > Cc: S, Ashraf Ali <[email protected]>; Rebecca Cran > <[email protected]>; Liming Gao <[email protected]>; Feng, Bob > C <[email protected]>; Chen, Christine <[email protected]>; > Chaganty, Rangasai V <[email protected]> > Subject: [PATCH] BaseTools: FMMT Skip empty Lines while parsing > FMMTConfig.ini > > When the FMMTConf.ini file has empty lines then it used to throw > errors GuidTool load error!, this patch is to skip checking for empty > lines in the ini file > > Cc: Rebecca Cran <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Bob Feng <[email protected]> > Cc: Yuwei Chen <[email protected]> > Cc: Chen Christine <[email protected]> > Cc: Chaganty Rangasai V <[email protected]> > > Signed-off-by: Ashraf Ali <[email protected]> > --- > BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py > b/BaseTools/Source/Python/FMMT/core/GuidTools.py > index f6bdeffa50..f9cfd4ead0 100644 > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py > @@ -153,7 +153,7 @@ class GUIDTools: > config_data = fd.readlines() > for line in config_data: > try: > - if not line.startswith("#"): > + if not line.startswith("#") and line.strip(): > guid, short_name, command = line.split() > new_format_guid = > struct2stream(ModifyGuidFormat(guid.strip())) > self.tooldef[new_format_guid] = GUIDTool( > -- > 2.42.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116611): https://edk2.groups.io/g/devel/message/116611 Mute This Topic: https://groups.io/mt/104620514/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
