Hi Prabin,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.muja...@arm.com>

Regards,

Sami Mujawar

On 11/03/2024 01:14 pm, Prabin CA wrote:
Enable ACPI CPPC mechanism for RD-Fremont as defined by the ACPI
specification. The implementation uses AMU registers accessible as
Fixed-feature Hardware (FFixedHW) for monitoring the performance.
Non-secure SCMI fastchannels are used to communicate with LCP to set the
desired performance. In addition to this, RD-Fremont platform does not
support CPPC revision 1 and below. So update the _OSC method to let OSPM
know about this fact.

Signed-off-by: Prabin CA <prabin...@arm.com>
---
  Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf |   1 +
  Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl      | 162 
++++++++++++++++++++
  2 files changed, 163 insertions(+)

diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf 
b/Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf
index 7556c1239116..fcaa3299c4ea 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf
@@ -48,6 +48,7 @@ [FixedPcd]
    gArmSgiTokenSpaceGuid.PcdGpioController0Interrupt
    gArmSgiTokenSpaceGuid.PcdGtFrame0Gsiv
    gArmSgiTokenSpaceGuid.PcdGtFrame1Gsiv
+  gArmSgiTokenSpaceGuid.PcdOscCppcEnable
    gArmSgiTokenSpaceGuid.PcdOscLpiEnable
    gArmSgiTokenSpaceGuid.PcdSp804DualTimerBaseAddress
    gArmSgiTokenSpaceGuid.PcdSp804DualTimerSize
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl 
b/Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl
index f921eeb2d99e..9c7266c79285 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl
@@ -11,6 +11,10 @@
  *   - ACPI 6.5, Chapter 8, Section 8.4.3, Lower Power Idle States
  *   - Arm Functional Fixed Hardware Specification v1.2, Chapter 3, Section 
3.1,
  *     Idle management and Low Power Idle states
+*   - ACPI 6.5, Chapter 8, Section 8.4.6, Collaborative Processor Performance
+*     Control
+*   - Arm Functional Fixed Hardware Specification v1.2, Chapter 3, Section 3.2,
+*     Performance management and Collaborative Processor Performance Control
  *
  **/
@@ -43,6 +47,20 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "ARMSGI",
                Or (STS0, OSC_STS_CAPABILITY_MASKED, STS0)
              }
            }
+
+          If (And (CAP0, OSC_CAP_CPPC_SUPPORT)) {
+            /* CPPC revision 1 and below not supported */
+            And (CAP0, Not (OSC_CAP_CPPC_SUPPORT), CAP0)
+            Or (STS0, OSC_STS_CAPABILITY_MASKED, STS0)
+          }
+
+          If (And (CAP0, OSC_CAP_CPPC2_SUPPORT)) {
+            if (LEqual (FixedPcdGet32 (PcdOscCppcEnable), Zero)) {
+              And (CAP0, Not (OSC_CAP_CPPC2_SUPPORT), CAP0)
+              Or (STS0, OSC_STS_CAPABILITY_MASKED, STS0)
+            }
+          }
+
          } Else {
            And (STS0, Not (OSC_STS_MASK), STS0)
            Or (STS0, Or (OSC_STS_FAILURE, OSC_STS_UNRECOGNIZED_REV), STS0)
@@ -116,6 +134,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 0)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x200093000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (0)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -131,6 +158,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 1)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x200293000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (1)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -146,6 +182,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 2)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x200493000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (2)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -161,6 +206,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 3)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x200693000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (3)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -176,6 +230,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 4)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x200893000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (4)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -191,6 +254,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 5)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x200A93000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (5)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -206,6 +278,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 6)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x200C93000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (6)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -221,6 +302,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 7)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x200E93000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (7)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -236,6 +326,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 8)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x201093000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (8)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -251,6 +350,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 9)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x201293000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (9)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -266,6 +374,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 10)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x201493000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (10)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -281,6 +398,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 11)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x201693000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (11)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -296,6 +422,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 12)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x201893000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (12)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -311,6 +446,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 13)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x201A93000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (13)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -326,6 +470,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 14)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x201C93000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (14)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }
@@ -341,6 +494,15 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", 
"ARMSGI",
          Name (_UID, 15)
          Name (_STA, 0xF)
+ Name (_CPC, Package()
+          CPPC_PACKAGE_INIT (0x201E93000, 0x0, 20, 160, 160, 85, 85, 5)
+        )
+
+        Name (_PSD, Package () {
+          Package ()
+            PSD_INIT (15)
+        })
+
          Method (_LPI, 0, NotSerialized) {
            Return (\_SB.PLPI)
          }


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117266): https://edk2.groups.io/g/devel/message/117266
Mute This Topic: https://groups.io/mt/104862640/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to