[AMD Official Use Only - General] > -----Original Message----- > From: Michael Brown <mc...@ipxe.org> > Sent: Tuesday, January 2, 2024 6:10 AM > To: Chang, Abner <abner.ch...@amd.com>; devel@edk2.groups.io > Cc: Saloni Kasbekar <saloni.kasbe...@intel.com>; Zachary Clark-williams > <zachary.clark-willi...@intel.com>; Nickle Wang <nick...@nvidia.com>; Igor > Kulchytskyy <ig...@ami.com> > Subject: Re: [PATCH 1/5] NetworkPkg/HttpDxe: Refactor TlsCreateChild > function > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 30/12/2023 11:29, abner.ch...@amd.com wrote: > > + @return EFI_SUCCESS TLS child handle is returned in HttpInstance- > >TlsChildHandle > > + with opened EFI_TLS_PROTOCOL and > EFI_TLS_CONFIGURATION_PROTOCOL. > > All looks good to me, but do we need to retain > HttpInstance->TlsChildHandle as a separate EFI_HANDLE field? Now that > EFI_TLS_PROTOCOL is installed on the same handle, it seems to function > solely as a flag to indicate that we have already called > TlsCreateChild(), in which case an EFI_BOOLEAN might be clearer? > > With or without the above suggestion, I'm happy to add That is no problem Michael, I also want to remove TlsChildHandle. Will send out V2 for this change.
> > Reviewed-by: Michael Brown <mc...@ipxe.org> Thanks Abner > > for this patch. > > Thanks, > > Michael -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113021): https://edk2.groups.io/g/devel/message/113021 Mute This Topic: https://groups.io/mt/103430430/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
