On 30/12/2023 11:29, abner.ch...@amd.com wrote:
+ @return EFI_SUCCESS TLS child handle is returned in HttpInstance->TlsChildHandle + with opened EFI_TLS_PROTOCOL and EFI_TLS_CONFIGURATION_PROTOCOL.
All looks good to me, but do we need to retain HttpInstance->TlsChildHandle as a separate EFI_HANDLE field? Now that EFI_TLS_PROTOCOL is installed on the same handle, it seems to function solely as a flag to indicate that we have already called TlsCreateChild(), in which case an EFI_BOOLEAN might be clearer?
With or without the above suggestion, I'm happy to add Reviewed-by: Michael Brown <mc...@ipxe.org> for this patch. Thanks, Michael -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113014): https://edk2.groups.io/g/devel/message/113014 Mute This Topic: https://groups.io/mt/103430430/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
