Similar comments as #1. Context could be NULL. Please add check before the assignment. With that, Reviewed-by: Ray Ni <[email protected]>
Thanks, Ray > -----Original Message----- > From: Wu, Jiaxin <[email protected]> > Sent: Tuesday, December 26, 2023 12:21 AM > To: [email protected] > Cc: Ni, Ray <[email protected]>; Gao, Liming <[email protected]> > Subject: [PATCH v2 2/6] MdeModulePkg/DebugAgentLibNull: Indicate SMM > Debug Agent support or not > > This patch is to use the Context to indicate SMM Debug Agent support or > not if InitFlag is DEBUG_AGENT_INIT_SMM. Context must point to a > BOOLEAN if it's not NULL. > > Cc: Ray Ni <[email protected]> > Cc: Liming Gao <[email protected]> > Signed-off-by: Jiaxin Wu <[email protected]> > --- > MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c | 9 > +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c > b/MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c > index 8e70705eb6..5596ee3bf9 100644 > --- a/MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c > +++ b/MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.c > @@ -22,10 +22,13 @@ > passing in the Context to be its parameter. > > If Function() is NULL, Debug Agent Library instance will return after setup > debug > environment. > > + If InitFlag is DEBUG_AGENT_INIT_SMM, Context must point to a BOOLEAN > if it's not > + NULL, which indicates SMM Debug Agent supported or not. > + > @param[in] InitFlag Init flag is used to decide the initialize process. > @param[in] Context Context needed according to InitFlag; it was > optional. > @param[in] Function Continue function called by debug agent library; it > was > optional. > > @@ -36,10 +39,16 @@ InitializeDebugAgent ( > IN UINT32 InitFlag, > IN VOID *Context OPTIONAL, > IN DEBUG_AGENT_CONTINUE Function OPTIONAL > ) > { > + switch (InitFlag) { > + case DEBUG_AGENT_INIT_SMM: > + *(BOOLEAN *)Context = FALSE; > + return; > + } > + > if (Function != NULL) { > Function (Context); > } > } > > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112900): https://edk2.groups.io/g/devel/message/112900 Mute This Topic: https://groups.io/mt/103360803/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
