Jiaxin, I missed one minor issue in offline review. Check below. Thanks, Ray
> + it will override IDT table entries and initialize debug port. Context must > + point to a BOOLEAN if it's not NULL, which indicates SMM Debug Agent > supported The comment says Context must point to a BOOLEAN "if it's not NULL". So, it's ok to be NULL. Then, the code below should modify the Context memory only when it's not NULL. With this change added, Reviewed-by: Ray Ni <ray...@intel.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112899): https://edk2.groups.io/g/devel/message/112899 Mute This Topic: https://groups.io/mt/103360802/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
