[AMD Official Use Only - General]
After addressing comment on 10/14, Reviewed-by: Abner Chang
<abner.ch...@amd.com>
> -----Original Message-----
> From: Mike Maslenkin <mike.maslen...@gmail.com>
> Sent: Friday, December 15, 2023 7:25 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <abner.ch...@amd.com>; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin <mike.maslen...@gmail.com>; Pedro Falcato
> <pedro.falc...@gmail.com>
> Subject: [PATCH v2 11/14] RedfishDiscoverDxe: refine InitInformationData(),
> remove unnecessary casts
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Cc: Abner Chang <abner.ch...@amd.com>
> Cc: Nickle Wang <nick...@nvidia.com>
> Cc: Igor Kulchytskyy <ig...@ami.com>
> Cc: Pedro Falcato <pedro.falc...@gmail.com>
> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
> ---
> .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +++++++++----------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> index 724aa35431a8..e3fc2d809dbc 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> @@ -730,12 +730,12 @@ VOID
> InitInformationData (
>
> IN EFI_REDFISH_DISCOVERED_INFORMATION *Information,
>
> IN UINTN *RedfishVersion OPTIONAL,
>
> - IN CHAR8 *RedfishLocation OPTIONAL,
>
> - IN CHAR8 *Uuid OPTIONAL,
>
> - IN CHAR8 *Os OPTIONAL,
>
> - IN CHAR8 *OsVer OPTIONAL,
>
> - IN CHAR8 *Product OPTIONAL,
>
> - IN CHAR8 *ProductVer OPTIONAL
>
> + IN CONST CHAR8 *RedfishLocation OPTIONAL,
>
> + IN CONST CHAR8 *Uuid OPTIONAL,
>
> + IN CONST CHAR8 *Os OPTIONAL,
>
> + IN CONST CHAR8 *OsVer OPTIONAL,
>
> + IN CONST CHAR8 *Product OPTIONAL,
>
> + IN CONST CHAR8 *ProductVer OPTIONAL
>
> )
>
> {
>
> if (RedfishVersion != NULL) {
>
> @@ -744,33 +744,33 @@ InitInformationData (
> }
>
>
>
> if (RedfishLocation != NULL) {
>
> - Information->Location = (CHAR16 *)AllocatePool (AsciiStrSize ((const
> CHAR8 *)RedfishLocation) * sizeof (CHAR16));
>
> - AsciiStrToUnicodeStrS ((const CHAR8 *)RedfishLocation, Information-
> >Location, AsciiStrSize ((const CHAR8 *)RedfishLocation) * sizeof (CHAR16));
>
> + Information->Location = AllocatePool (AsciiStrSize (RedfishLocation) *
> sizeof (CHAR16));
>
> + AsciiStrToUnicodeStrS (RedfishLocation, Information->Location,
> AsciiStrSize (RedfishLocation) * sizeof (CHAR16));
>
> DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n",
> Information->Location));
>
> }
>
>
>
> if (Uuid != NULL) {
>
> - Information->Uuid = (CHAR16 *)AllocatePool (AsciiStrSize ((const CHAR8
> *)Uuid) * sizeof (CHAR16));
>
> - AsciiStrToUnicodeStrS ((const CHAR8 *)Uuid, Information->Uuid,
> AsciiStrSize ((const CHAR8 *)Uuid) * sizeof (CHAR16));
>
> + Information->Uuid = AllocatePool (AsciiStrSize (Uuid) * sizeof (CHAR16));
>
> + AsciiStrToUnicodeStrS (Uuid, Information->Uuid, AsciiStrSize (Uuid) *
> sizeof (CHAR16));
>
> DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information-
> >Uuid));
>
> }
>
>
>
> if (Os != NULL) {
>
> - Information->Os = (CHAR16 *)AllocatePool (AsciiStrSize ((const CHAR8
> *)Os) * sizeof (CHAR16));
>
> - AsciiStrToUnicodeStrS ((const CHAR8 *)Os, Information->Os, AsciiStrSize
> ((const CHAR8 *)Os) * sizeof (CHAR16));
>
> + Information->Os = AllocatePool (AsciiStrSize (Os) * sizeof (CHAR16));
>
> + AsciiStrToUnicodeStrS (Os, Information->Os, AsciiStrSize (Os) * sizeof
> (CHAR16));
>
> DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, Version:%s.\n",
> Information->Os, Information->OsVersion));
>
> }
>
>
>
> if (OsVer != NULL) {
>
> - Information->OsVersion = (CHAR16 *)AllocatePool (AsciiStrSize ((const
> CHAR8 *)OsVer) * sizeof (CHAR16));
>
> - AsciiStrToUnicodeStrS ((const CHAR8 *)OsVer, Information->OsVersion,
> AsciiStrSize ((const CHAR8 *)OsVer) * sizeof (CHAR16));
>
> + Information->OsVersion = AllocatePool (AsciiStrSize (OsVer) * sizeof
> (CHAR16));
>
> + AsciiStrToUnicodeStrS (OsVer, Information->OsVersion, AsciiStrSize
> (OsVer)
> * sizeof (CHAR16));
>
> }
>
>
>
> if ((Product != NULL) && (ProductVer != NULL)) {
>
> - Information->Product = (CHAR16 *)AllocatePool (AsciiStrSize ((const
> CHAR8 *)Product) * sizeof (CHAR16));
>
> - AsciiStrToUnicodeStrS ((const CHAR8 *)Product, Information->Product,
> AsciiStrSize ((const CHAR8 *)Product) * sizeof (CHAR16));
>
> - Information->ProductVer = (CHAR16 *)AllocatePool (AsciiStrSize ((const
> CHAR8 *)ProductVer) * sizeof (CHAR16));
>
> - AsciiStrToUnicodeStrS ((const CHAR8 *)ProductVer, Information-
> >ProductVer, AsciiStrSize ((const CHAR8 *)ProductVer) * sizeof (CHAR16));
>
> + Information->Product = AllocatePool (AsciiStrSize (Product) * sizeof
> (CHAR16));
>
> + AsciiStrToUnicodeStrS (Product, Information->Product, AsciiStrSize
> (Product) * sizeof (CHAR16));
>
> + Information->ProductVer = AllocatePool (AsciiStrSize (ProductVer) *
> sizeof
> (CHAR16));
>
> + AsciiStrToUnicodeStrS (ProductVer, Information->ProductVer, AsciiStrSize
> (ProductVer) * sizeof (CHAR16));
>
> DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s,
> Version:%s.\n", Information->Product, Information->ProductVer));
>
> }
>
> }
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112629): https://edk2.groups.io/g/devel/message/112629
Mute This Topic: https://groups.io/mt/103181047/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
