[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.ch...@amd.com>
> -----Original Message-----
> From: Mike Maslenkin <mike.maslen...@gmail.com>
> Sent: Friday, December 15, 2023 7:25 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <abner.ch...@amd.com>; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin <mike.maslen...@gmail.com>
> Subject: [PATCH v2 07/14] RedfishPkg: add proper initialization of IPMI
> request
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be
> initialized to avoid error condition on BMC side.
>
> Cc: Abner Chang <abner.ch...@amd.com>
> Cc: Nickle Wang <nick...@nvidia.com>
> Cc: Igor Kulchytskyy <ig...@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
> ---
> .../PlatformHostInterfaceBmcUsbNicLib.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> index 7f295fe7f1c0..c73e76df5791 100644
> ---
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> +++
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> @@ -616,9 +616,10 @@ HostInterfaceIpmiCheckMacAddress (
> }
>
>
>
> // Initial the get MAC address request.
>
> - GetLanConfigReq.SetSelector = 0;
>
> - GetLanConfigReq.BlockSelector = 0;
>
> - GetLanConfigReq.ParameterSelector = IpmiLanMacAddress;
>
> + GetLanConfigReq.ChannelNumber.Uint8 = 0;
>
> + GetLanConfigReq.SetSelector = 0;
>
> + GetLanConfigReq.BlockSelector = 0;
>
> + GetLanConfigReq.ParameterSelector = IpmiLanMacAddress;
>
>
>
> ExitStatus = EFI_NOT_FOUND;
>
> for (ChannelNum =
> IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_1;
>
> @@ -640,6 +641,7 @@ HostInterfaceIpmiCheckMacAddress (
> } else {
>
> DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " No cached IPMI LAN
> info\n"));
>
> DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Send NetFn = App,
> Command = 0x42 to channel %d\n", ChannelNum));
>
> + GetChanelInfoRequest.ChannelNumber.Uint8 = 0;
>
> GetChanelInfoRequest.ChannelNumber.Bits.ChannelNo =
> (UINT8)ChannelNum;
>
> Status = IpmiGetChannelInfo
> (
>
>
> &GetChanelInfoRequest,
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112624): https://edk2.groups.io/g/devel/message/112624
Mute This Topic: https://groups.io/mt/103181042/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
